Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Builder to evaluate the bsn and version of the project #4712

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 12, 2025

Currently if the version contains an evaluated expression this is used as is and maven complains about that.

This now use the ProjectBuilder to evaluate the actual version and bsn.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Feb 12, 2025
@laeubi laeubi enabled auto-merge (rebase) February 12, 2025 05:03
@laeubi laeubi disabled auto-merge February 12, 2025 05:17
Currently if the version contains an evaluated expression this is used
as is and maven complains about that.

This now use the ProjectBuilder to evaluate the actual version and bsn.
@laeubi laeubi force-pushed the evaluate_version_and_bsn branch from 850801f to 5996913 Compare February 12, 2025 05:40
@laeubi laeubi enabled auto-merge (rebase) February 12, 2025 05:40
Copy link

Test Results

  609 files  ±0    609 suites  ±0   3h 58m 3s ⏱️ - 3h 16m 12s
  435 tests ±0    426 ✅  - 1   7 💤 ±0  1 ❌ ±0  1 🔥 +1 
1 305 runs  ±0  1 279 ✅  - 3  22 💤 ±0  1 ❌ ±0  3 🔥 +3 

For more details on these failures and errors, see this check.

Results for commit 5996913. ± Comparison against base commit 6d105c6.

@laeubi laeubi disabled auto-merge February 12, 2025 09:39
@laeubi laeubi merged commit 04710cf into eclipse-tycho:main Feb 12, 2025
10 of 15 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants