Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bndtools workspace template fragment #4685

Conversation

chrisrueger
Copy link
Contributor

This adds a Workspace Template Fragment which can be used by bndtools users to create a new Bnd Workspace.

See https://bnd.bndtools.org/chapters/620-template-fragments.html for more information.

Next steps

After this folder is available on github (e.g. in master branch):

Onces that is done, all bnd tools users will see a new entry for Eclipse Tycho Maven in bndtools, like this:

image

Why

It is just a useful addition to promote the ability of Tycho to build Bnd Workspaces.

@chrisrueger chrisrueger marked this pull request as ready for review February 3, 2025 14:20
@chrisrueger chrisrueger force-pushed the add-bndtools-workspace-template-fragment branch from dfd5957 to f8ae7d4 Compare February 3, 2025 14:21
@chrisrueger chrisrueger force-pushed the add-bndtools-workspace-template-fragment branch 2 times, most recently from 0f43320 to e2f1217 Compare February 3, 2025 15:24
@chrisrueger
Copy link
Contributor Author

All suggestions fixed. I moved more stuff to BndBuild.md

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall looks good to me, please squash your commits into one so we can easier back-port this!

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Feb 3, 2025
@chrisrueger chrisrueger force-pushed the add-bndtools-workspace-template-fragment branch from 2c543dc to 6f500ad Compare February 3, 2025 15:31
Copy link

github-actions bot commented Feb 3, 2025

Test Results

  606 files  ±0    606 suites  ±0   4h 20m 11s ⏱️ + 21m 4s
  434 tests ±0    426 ✅ ±0   7 💤 ±0  1 ❌ ±0 
1 302 runs  ±0  1 279 ✅ ±0  22 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6f500ad. ± Comparison against base commit 807bd8e.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the suggest changes will improve the documentation (of this cool new feature).

@chrisrueger chrisrueger force-pushed the add-bndtools-workspace-template-fragment branch 2 times, most recently from b700172 to 62317e4 Compare February 4, 2025 11:26
@chrisrueger
Copy link
Contributor Author

Thanks a lot @merks for the readme suggestions. I committed them all.
@laeubi I squashed all commits. Ready to go I think.

Update BndBuild.md

Apply suggestions from code review

Co-Authored-By: Ed Merks <Ed.Merks@gmail.com>
Co-Authored-By: Christoph Läubrich <mail@laeubi-soft.de>
@chrisrueger chrisrueger force-pushed the add-bndtools-workspace-template-fragment branch from b1d565f to 0a46e00 Compare February 4, 2025 11:29
@laeubi
Copy link
Member

laeubi commented Feb 4, 2025

Build will not verify this ..

@laeubi laeubi merged commit ff5dbb6 into eclipse-tycho:main Feb 4, 2025
13 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants