Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compare-versions-with-baseline failing (since 2.7) when executionEnvironment=none #707

Closed
mickaelistria opened this issue Mar 1, 2022 · 2 comments · Fixed by #709
Closed

compare-versions-with-baseline failing (since 2.7) when executionEnvironment=none #707

mickaelistria opened this issue Mar 1, 2022 · 2 comments · Fixed by #709
Milestone
2.7.1

Comments

@mickaelistria
Copy link
Contributor

When using compare-versions-with-baseline mojo on a module which set <executionEnvironment>none</executionEnvironment>, the following exception is thrown

[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines (compare-version-with-baseline) on project repository: Execution compare-version-with-baseline of goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines failed: Cannot set full specification for a custom profile more than once -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines (compare-version-with-baseline) on project repository: Execution compare-version-with-baseline of goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines failed: Cannot set full specification for a custom profile more than once
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution compare-version-with-baseline of goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines failed: Cannot set full specification for a custom profile more than once
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: java.lang.IllegalStateException: Cannot set full specification for a custom profile more than once
    at org.eclipse.tycho.core.ee.ExecutionEnvironmentConfigurationImpl.setFullSpecificationForCustomProfile (ExecutionEnvironmentConfigurationImpl.java:122)
    at org.eclipse.tycho.p2.target.ee.StandardEEResolutionHandler.readFullSpecification (StandardEEResolutionHandler.java:49)
    at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.createTargetPlatform (TargetPlatformFactoryImpl.java:195)
    at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.createTargetPlatform (TargetPlatformFactoryImpl.java:134)
    at org.eclipse.tycho.p2.target.TargetPlatformFactoryImpl.createTargetPlatform (TargetPlatformFactoryImpl.java:1)
    at org.eclipse.tycho.plugins.p2.extras.CompareWithBaselineMojo.execute (CompareWithBaselineMojo.java:135)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR]

This is a regression from 11f7c9d which introduce some execution stacks calling environmentConfiguration.setFullSpecificationForCustomProfile multiple times which it's not supposed to happen. One pre-existing issue that can be part of the cause here is ExecutionEnvironmentImpl.isCustomProfile returning true if no EE is to be injected.
@mickaelistria mickaelistria mentioned this issue Mar 1, 2022
Closed
@laeubi
Copy link
Member

laeubi commented Mar 1, 2022

Do you think you can derive an integration test for this or small example project to investigate this further?

@mickaelistria
Copy link
Contributor Author

I'm working on it and have a minimal test. I'm trying to also implement a fix and hope I can submit them together as a PR before the end of this day.

mickaelistria added a commit to mickaelistria/tycho that referenced this issue Mar 1, 2022
@mickaelistria
Issue eclipse-tycho#707 - fix logic detecting custom vs none EE profile
b7143d2 
Fix some methods and conditions to better distinguish cases of ee=none
vs custom EE.
This allows further invocations of
TargetPlatformFactoryImpl.createTargetPlatform to work with ee=none.
@mickaelistria mickaelistria linked a pull request Mar 1, 2022 that will close this issue
Issue #707 - fix logic detecting custom vs none EE profile #709
Merged
mickaelistria added a commit to mickaelistria/tycho that referenced this issue Mar 1, 2022
@mickaelistria
Issue eclipse-tycho#707 - fix logic detecting custom vs none EE profile
72d227c 
Fix some methods and conditions to better distinguish cases of ee=none
vs custom EE.
This allows further invocations of
TargetPlatformFactoryImpl.createTargetPlatform to work with ee=none.
mickaelistria added a commit that referenced this issue Mar 1, 2022
@mickaelistria
Issue #707 - fix logic detecting custom vs none EE profile
910bda6 
Fix some methods and conditions to better distinguish cases of ee=none
vs custom EE.
This allows further invocations of
TargetPlatformFactoryImpl.createTargetPlatform to work with ee=none.
akurtakov added a commit to akurtakov/corrosion that referenced this issue Mar 2, 2022
@akurtakov
Build with Tycho 3.0.0 for eclipse-tycho/tycho#707
652356d
mickaelistria pushed a commit to eclipse-corrosion/corrosion that referenced this issue Mar 14, 2022
@akurtakov @mickaelistria
Build with Tycho 3.0.0 for eclipse-tycho/tycho#707
585cf02
@laeubi laeubi added this to the 2.7.1 milestone Mar 30, 2022
laeubi pushed a commit that referenced this issue Mar 30, 2022
@mickaelistria @laeubi
Issue #707 - fix logic detecting custom vs none EE profile
71177ae 
Fix some methods and conditions to better distinguish cases of ee=none
vs custom EE.
This allows further invocations of
TargetPlatformFactoryImpl.createTargetPlatform to work with ee=none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.1
Development

Successfully merging a pull request may close this issue.

Issue #707 - fix logic detecting custom vs none EE profile mickaelistria/tycho
2 participants
@mickaelistria @laeubi