Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changelog): updated CHANGELOG.md with 0.5.0 and 0.5.1 #733

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

saschaisele-zf
Copy link
Contributor

WHAT

recovered CHANGELOG.md from 0.5.0-rc5
copied generated changelogs from releases 0.5.0 and 0.5.1
added links
fixed all linting errors in the old file

WHY

Closes
#723

@saschaisele-zf saschaisele-zf added the documentation Improvements or additions to documentation label Aug 25, 2023
@saschaisele-zf saschaisele-zf self-assigned this Aug 25, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@wolf4ood
Copy link
Contributor

@saschaisele-zf i see some errors in the dependencies check, try to rebase from main

@saschaisele-zf
Copy link
Contributor Author

rebased and branch is up-to-date but the test still fails ... I am confused

@wolf4ood
Copy link
Contributor

Do you know how to update the DEPEDENCIES file with the dash tool? Probably something has changed there

in case you can download the dash tool

curl -L https://repo.eclipse.org/service/local/artifact/maven/redirect\?r\=dash-licenses\&g\=org.eclipse.dash\&a\=org.eclipse.dash.licenses\&v\=LATEST --output dash.jar

and then from the project folder

./gradlew allDependencies | ack -Poh “(?<=\s)[\w.-]+:[\w.-]+:[^:\s\[\]]+” | sort | uniq | java -jar <path_to_dash> - -summary DEPENDENCIES

@saschaisele-zf
Copy link
Contributor Author

On it ... might take a bit until I got it to run on my windows machine :)

@ndr-brt
Copy link
Contributor

ndr-brt commented Aug 28, 2023

On it ... might take a bit until I got it to run on my windows machine :)

you don't need to run it, you can get the expected DEPENDENCIES content from the job log output: https://github.com/eclipse-tractusx/tractusx-edc/actions/runs/5999939816/job/16271052798?pr=733

@saschaisele-zf
Copy link
Contributor Author

copying it from the task did not work it seems

@wolf4ood
Copy link
Contributor

@saschaisele-zf probably something change on dash side in the meanwhile, try to fetch the latest version from the last failed run

https://github.com/eclipse-tractusx/tractusx-edc/actions/runs/6009484962/job/16299013413?pr=733

@saschaisele-zf
Copy link
Contributor Author

tried that already
leads to no changes in the file

@saschaisele-zf
Copy link
Contributor Author

taking the dependency file from the main branch leads me to one difference
will try it with that one instead

@saschaisele-zf saschaisele-zf force-pushed the changelog branch 4 times, most recently from 82bd369 to 74da0d0 Compare August 29, 2023 08:35
recovered CHANGELOG.md from 0.5.0-rc5
copied generated changelogs from releases 0.5.0 and 0.5.1
added links
fixed all linting errors in the old file
fixed some more lint errors
removed semver statement
updated dependencies

Signed-off-by: Sascha Isele <sascha.isele.external@zf.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wolf4ood wolf4ood merged commit 2a8d69b into eclipse-tractusx:main Aug 29, 2023
@saschaisele-zf saschaisele-zf deleted the changelog branch August 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants