Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download opentelemetry jar outside of Dockerfile #697

Conversation

paullatzelsperger
Copy link
Contributor

WHAT

Downloads the OpenTelemetry Agent jar "outside" of the Dockerfile. This is actually done in two locations:

  1. the build.gradle.kts file: a Gradle task is added for this
  2. the publish-docker-image action: a GH Actions step is added, because when publishing we don't use the Gradle Docker task

WHY

Downloading the OTEL Agent inside Docker required adding curl first, and due to security restrictions that required a fixed version. APK, Alpine Linux's package manager, seems to not keep older versions around, which caused the build to break whenever a new version of curl was released.

FURTHER NOTES

  • Docker can't use resources outside of its build context, that is why the Gradle task downloads the opentelemetry-javaagent.jar once per project, directly to each project's build/ folder.

Closes #686

@paullatzelsperger paullatzelsperger force-pushed the feat/686_download_opentelemetry_jar_only_once branch 2 times, most recently from 6153bc9 to a102972 Compare August 8, 2023 10:34
@paullatzelsperger paullatzelsperger force-pushed the feat/686_download_opentelemetry_jar_only_once branch from a102972 to a7dd745 Compare August 8, 2023 10:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger merged commit f7441b7 into eclipse-tractusx:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Dockerfiles: download opentelemetry-javaagent.jar externally
3 participants