Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve bpn validation #687

Merged
merged 12 commits into from
Aug 3, 2023
Merged

feat: improve bpn validation #687

merged 12 commits into from
Aug 3, 2023

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Aug 2, 2023 •
edited
Loading

WHAT

Improves the BPN validation in the following aspects:

  • BPNs are not hardcoded on the policy anymore
  • BPNs are stored in a small persistence backend (in-mem + postgres are available)
  • the evaluation function understands a few more operators

WHY

The old BPN validation extension was inflexible and not scalable and there were technical errors in it.

FURTHER NOTES

  • For compatibility reasons the old policy evaluation will remain in place but issue a deprecation warning.
  • I unimaginatively called the new module business-partner-validation2 - suggestions welcome
  • the new module isn't yet used anywhere - e2e tests, runtimes, docker images, helm charts... that'll come in another PR
  • [edit] a REST API to manipulate BPN+groups will follow in another PR

Closes #673

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Aug 2, 2023
@paullatzelsperger paullatzelsperger marked this pull request as ready for review August 2, 2023 18:20
@paullatzelsperger paullatzelsperger force-pushed the feat/673_improve_bpn_validation branch from dcaef70 to ba838df Compare August 2, 2023 18:26
@paullatzelsperger paullatzelsperger changed the title Feat/673 improve bpn validation feat: improve bpn validation Aug 2, 2023
@paullatzelsperger paullatzelsperger force-pushed the feat/673_improve_bpn_validation branch from 86bd0ab to 2392231 Compare August 3, 2023 05:41
@paullatzelsperger paullatzelsperger force-pushed the feat/673_improve_bpn_validation branch from 2392231 to 4fbc215 Compare August 3, 2023 05:41
ndr-brt
ndr-brt approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe bpn-validation could be good for naming?

@wolf4ood
Copy link
Contributor

wolf4ood commented Aug 3, 2023

👍 for bpn-validation

jimmarino
jimmarino requested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far. Two things:

  1. We should have a DR for this
  2. The left operand should have a prefix/namespace as explained in the one comment

...clipse/tractusx/edc/validation/businesspartner/store/sql/BusinessPartnerGroupStatements.java Show resolved Hide resolved
.../org/eclipse/tractusx/edc/validation/businesspartner/BusinessPartnerEvaluationExtension.java Outdated Show resolved Hide resolved
@paullatzelsperger paullatzelsperger force-pushed the feat/673_improve_bpn_validation branch from ed74b1c to 6d8a223 Compare August 3, 2023 07:16
@paullatzelsperger
Copy link
Contributor Author

paullatzelsperger commented Aug 3, 2023 •
edited
Loading

Looks great so far. Two things:

  1. We should have a DR for this
  2. The left operand should have a prefix/namespace as explained in the one comment

DR incoming.

@paullatzelsperger paullatzelsperger force-pushed the feat/673_improve_bpn_validation branch from 64c9671 to bcfd0b7 Compare August 3, 2023 07:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger merged commit d8b54dd into eclipse-tractusx:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmarino jimmarino jimmarino approved these changes

@ndr-brt ndr-brt ndr-brt approved these changes

@wolf4ood wolf4ood wolf4ood approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the business-partner-validation extensions
4 participants
@paullatzelsperger @wolf4ood @jimmarino @ndr-brt