Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify data encryptor #678

Merged
merged 7 commits into from
Jul 29, 2023
Merged

feat: simplify data encryptor #678

merged 7 commits into from
Jul 29, 2023

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Jul 28, 2023 •
edited
Loading

WHAT

Replaces the old, quite convoluted AES data encryptor extension with a sleeker one.
In addition, the bouncy castle provider was replaced with a plain JCE implementation.

WHY

Simplification of code. We don't need layers on layers of factories and providers. KISS.

FURTHER NOTES

  • Currently only AES/GCM with a 128 bit IV is supported. A NoopEncryptor is instantiated as fallback.
  • Postgres test setup was improved slightly

Closes #672

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jul 28, 2023
@paullatzelsperger paullatzelsperger self-assigned this Jul 28, 2023
@paullatzelsperger paullatzelsperger changed the title Feat/672 simplify data encryptor feat: simplify data encryptor Jul 28, 2023
jimmarino
jimmarino approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

ndr-brt
ndr-brt approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 🪓 🪓

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger merged commit 4c3c559 into eclipse-tractusx:main Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

@jimmarino jimmarino jimmarino approved these changes

@wolf4ood wolf4ood Awaiting requested review from wolf4ood

Assignees

@paullatzelsperger paullatzelsperger

Labels
enhancement New feature or request
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify the DataEncrypter
3 participants
@paullatzelsperger @jimmarino @ndr-brt