Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add API tests for MIW #555

Closed
wants to merge 0 commits into from
Closed

feat: add API tests for MIW #555

wants to merge 0 commits into from

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Jul 3, 2023 •
edited
Loading

WHAT

this PR adds tests that assert basic functionality of the MIW (and by extension: the SSI lib).

WHY

Tractus-X EDC relies on MIW as the sole identity backend, so it must make sure that certain functionalities, without which EDC is not functional, are provided.

FURTHER NOTES

  • the test uses the latest-java-did-web tag of the MIW docker image to avoid stale tests
  • currently, the MIW tests are marked continue-on-error, so that they don't block our CI
  • added healthcheck configs to keycloak and postgres
  • added a custom wait script for MIW to become available
  • seeding SQL test data was moved into a separate script (seed.sh), to avoid race conditions between Postgres and MIW

Closes # <-- insert Issue number if one exists

@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch 2 times, most recently from bed9563 to 442c3a7 Compare July 3, 2023 07:42
@paullatzelsperger paullatzelsperger changed the title Feature/add miw api tests feat: add API tests for MIW Jul 3, 2023
wolf4ood
wolf4ood approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🚀

@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch 5 times, most recently from 5eff9c3 to cb43149 Compare July 4, 2023 06:07
@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch from cb43149 to 60dd5b9 Compare July 4, 2023 09:49
@paullatzelsperger
Copy link
Contributor Author

paullatzelsperger commented Jul 4, 2023 •
edited
Loading

although the MIW compliance tests are flagged with continue-on-error i'll hold off with the merge until the bugs in MIW are actually fixed, because Github will still report the test as failed, which pollutes our upstream actions log.

@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch 3 times, most recently from 12620d7 to df46a77 Compare July 7, 2023 06:34
@paullatzelsperger paullatzelsperger force-pushed the feature/add_miw_api_tests branch from df46a77 to f052433 Compare July 7, 2023 06:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger mentioned this pull request Jul 7, 2023
Merged
@paullatzelsperger
Copy link
Contributor Author

PR had to be closed due to some rebasing problems. Reopened -> #585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

@wolf4ood wolf4ood wolf4ood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paullatzelsperger @wolf4ood @ndr-brt