feat: Initial implementation of Catena-X policies #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c146d73 to
e2a5fbf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| * Converts the value to a string representation. | ||
| */ | ||
| @Nullable | ||
| private static String convertType(JsonValue value) { |
There was a problem hiding this comment.
eventually we'll likely want to upstream these utilities
There was a problem hiding this comment.
Yeah, I thinking we need separate set of Json-Ld utils.
| /** | ||
| * Returns true if the actual operand value is a string literal case-insensitive equal to the expected value. | ||
| */ | ||
| protected boolean validateRightOperand(String expectedValue, Object actualValue, PolicyContext context) { |
There was a problem hiding this comment.
I think the expected value should be a vararg, because there could be several allowed ones, same as we have for the validateOperator
There was a problem hiding this comment.
I think the expected value should be a vararg, because there could be several allowed ones, same as we have for the
validateOperator
Yeah, that method is going to actually have to be modified when we switch versions from the left to right operand as described here. I'll do that in another PR.
wolf4ood
approved these changes
Jun 14, 2023
paullatzelsperger
approved these changes
Jun 14, 2023
249bd8a
into
eclipse-tractusx:previews/preview_0_1_1_snapshot
paullatzelsperger
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Initial implementation of Catena-X policies * Add header * Fix checkstyle * Fix typo * Fix typo * Add javadoc * Add javadoc * Switch token eval to a policy validator function
paullatzelsperger
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Initial implementation of Catena-X policies * Add header * Fix checkstyle * Fix typo * Fix typo * Add javadoc * Add javadoc * Switch token eval to a policy validator function
paullatzelsperger
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Initial implementation of Catena-X policies * Add header * Fix checkstyle * Fix typo * Fix typo * Add javadoc * Add javadoc * Switch token eval to a policy validator function
paullatzelsperger
added a commit
that referenced
this pull request
Jun 21, 2023
* feat: upgrade to 0.1.1-SNAPSHOT, fix resulting compile errors * chore: fix tests (#479) * feat: Initial implementation of Catena-X policies (#477) * Initial implementation of Catena-X policies * Add header * Fix checkstyle * Fix typo * Fix typo * Add javadoc * Add javadoc * Switch token eval to a policy validator function * chore: fix tests (#481) * feat(policy): (#487) * Cleanup namespaces, add extension class, implement summary constraint * Update credential names; add rule bindings * feat(SSI): implements the MIW client with Oauth2 as token provider for using the MIW APIs (#489) * fix: version catalog * feat(ParticipantIdentity): implements the ID extractor (#504) * feat(ParticipantIdentity): implements the ID extractor for the summary credential + E2E test * feat(ParticipantIdentity): more tests and ID extractor exception if identity not extracted * feat(ParticipantIdentity): add audience validation + tests * fix after review * remove short-term cache invalidation --------- Co-authored-by: Enrico Risa <enrico.risa@gmail.com> Co-authored-by: Jim Marino <jim.marino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR provides an initial implementation of SSI policies per this specification and the Summary Credential.
FURTHER NOTES
The CX policy module contains functions for working with Json-Ld structures. These functions (
JsonLdTypeFunctionsandJsonLdValueFunctions) will likely be refactored into a common module and shared with the new SSI-basedIdentityServicein a subsequent PR.Closes #476