Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Adapt "Local TXDC Setup.md" #354

Closed
wants to merge 1 commit into from
Closed

docs: Adapt "Local TXDC Setup.md" #354

wants to merge 1 commit into from

Conversation

tuncaytunc-zf
Copy link
Contributor

WHAT

Adapt "Local TXDC Setup.md"

WHY

The documentation was outdated

Closes #286

@tuncaytunc-zf tuncaytunc-zf added the documentation Improvements or additions to documentation label May 16, 2023
ghost
ghost suggested changes May 16, 2023
View reviewed changes
charts/tractusx-connector-azure-vault/README.md Outdated Show resolved Hide resolved
charts/tractusx-connector-memory/README.md Outdated Show resolved Hide resolved
charts/tractusx-connector/README.md Outdated Show resolved Hide resolved
@tuncaytunc-zf tuncaytunc-zf force-pushed the docu/adaptLocalTxdcSetup branch from 396c06d to c86b34d Compare May 17, 2023 11:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tuncaytunc-zf tuncaytunc-zf requested a review from a user May 17, 2023 11:35
@florianrusch-zf florianrusch-zf requested review from florianrusch-zf and removed request for a user May 17, 2023 11:37
@florianrusch-zf
Copy link
Contributor

@stephanbcbauer do you still want to have a look on this? Or can we merge this?

stephanbcbauer
stephanbcbauer approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paullatzelsperger
Copy link
Contributor

business tests are gone, seems this doc isn't needed anymore? If we want to document the deployment tests, please note PR #400.

@paullatzelsperger paullatzelsperger mentioned this pull request May 23, 2023
Closed
@stephanbcbauer
Copy link
Member

business tests are gone, seems this doc isn't needed anymore? If we want to document the deployment tests, please note PR #400.

Could this still be used as an installation/setup manual? @tuncaytunc-zf , @paullatzelsperger

@paullatzelsperger
Copy link
Contributor

Partly, yes. Please note my comments in #400

@stephanbcbauer
Copy link
Member

@tuncaytunc-zf please lets discuss this PR and if the file is still needed.thx

@tuncaytunc-zf
Copy link
Contributor Author

I think this documentation is no more required, since the charts has been changed totally and there exists already other docus.

@tuncaytunc-zf
Copy link
Contributor Author

will create another PR to delete this docu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger left review comments

@florianrusch-zf florianrusch-zf florianrusch-zf approved these changes

@stephanbcbauer stephanbcbauer stephanbcbauer approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
EDC PR Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update used image version in documentation
4 participants
@tuncaytunc-zf @florianrusch-zf @paullatzelsperger @stephanbcbauer