Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataEncryption): removes lombok from data-encryption module #179

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Apr 4, 2023

This PR is the first one of the story #150 lombok for the DR #143 .

The main target of this RP is the edc-extensions:data-encryption module.

Linked Issues

Closes #153

@wolf4ood wolf4ood marked this pull request as ready for review April 4, 2023 14:35
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@florianrusch-zf florianrusch-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂 Just two smaller comments

…usx/edc/data/encryption/algorithms/aes/AesAlgorithmTest.java

Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <florian.rusch.external@zf.com>
@florianrusch-zf florianrusch-zf merged commit 7d58dea into eclipse-tractusx:develop Apr 5, 2023
@florianrusch-zf florianrusch-zf deleted the feature/153_remove_lombok_data_encryption branch April 5, 2023 08:11
paullatzelsperger pushed a commit to paullatzelsperger/tractusx-edc that referenced this pull request May 4, 2023
paullatzelsperger pushed a commit that referenced this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants