Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snapshot workflow): Allow snapshots from bugfix branches #1558

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

rafaelmag110
Copy link
Contributor

WHAT

This PR proposes a refactor to the determine-version job of the publish-new-snapshot workflow, that improves the job to resolve the correct snapshot version string from the gradle.properties every time. This version string is then used as input for the various publishing workflows.

As the publish-new-snapshot workflow can be manually activated, this improvement also allows for the creation of a snapshot from any branch.

WHY

To allow snapshots from bugfix branches.

FURTHER NOTES

In light of #1543, also took the opportunity to remove some unnecessary "listeners" from the run-all-tests workflow, making the file simpler.

  • Removed any reference to the releases branch as its not needed anymore.
  • Removed any reference to previews/* branches as they are not needed anymore.
  • Checking if the github.event_name == pull_request is redundant, since that event can't trigger the workflow.
  • We don't need to run all tests on tag push or release publication, since the tests were already executed a) on PR and b) on the branch from where the tag/release will be pushed/published.

Closes #1557

Copy link

@rafaelmag110
Copy link
Contributor Author

@ndr-brt ndr-brt merged commit b8db9bf into eclipse-tractusx:main Sep 17, 2024
33 checks passed
@rafaelmag110 rafaelmag110 deleted the improve_snapshot_workflow branch September 17, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Publish New Snapshot should work for bugfix branches
4 participants