Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Mock-EDC and a sample how to use it #1264

Merged

Conversation

paullatzelsperger
Copy link
Contributor

WHAT

This PR adds a stub for EDCs Management API in the form of a standalone Docker image. It enables downstream projects to use this stub as a drop-in replacement for the connector to decrease friction and facilitate easier CI/CD integration.

WHY

Contract-based testing should be more widely used in Tractus-X.

FURTHER NOTES

  • An additional docker image will published after this PR is merged

Closes # <-- insert Issue number if one exists

@paullatzelsperger paullatzelsperger marked this pull request as ready for review May 2, 2024 05:38
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really amazing! Only a comment about the name, all good for the rest.

docs/development/mock-edc.md Outdated Show resolved Hide resolved
* adds a {@link RecordedRequest}
*/
public void append(RecordedRequest<?, ?> recordedRequest) {
recordedRequests.offer(recordedRequest);

Check notice

Code scanning / CodeQL

Ignored error status of call Note

Method append ignores exceptional return value of Queue<RecordedRequest>.offer.
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@paullatzelsperger paullatzelsperger merged commit 622b81d into eclipse-tractusx:main May 3, 2024
31 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/mocked_Edc branch May 3, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants