Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update management api walkthrough #1242

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

drandarov-io
Copy link
Contributor

This is a partial update to the Management API Walkthrough with focus on the payloads and consistency.

Not considered for now:

@arnoweiss
Copy link
Contributor

There's currently a different PR (#1241) open that will likely introduce conflicts to the base branch. Since it's more extensive, I'd suggest merging that one first and then adjusting this one.

@drandarov-io
Copy link
Contributor Author

Re-created commit, because commit signature was unverified.

@wolf4ood
Copy link
Contributor

@drandarov-io #1241 has been merged you can rebase and apply your changes
Thanks

@arnoweiss
Copy link
Contributor

Do you intend to add the issues "not considered for now" to this PR? If yes, please convert this back to a draft. If no, this PR covers mostly formatting.

@drandarov-io
Copy link
Contributor Author

I believe PR #1241 covered most of the 0.7.0 changes (like properties being renamed or removed) so for the most part all that is left in the diff is formatting. Therefore, I'd say from my side, the PR ist finished.

@wolf4ood wolf4ood self-requested a review April 19, 2024 09:48
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i would just fix the DEPENDENCIES file.

You can go here grab the content between

=== Please copy the following content back to DEPENDENCIES ===
...
=== end of content ===

and pasted in the DEPENDENCIES file and should fix the CI

@arnoweiss
Copy link
Contributor

I believe PR #1241 covered most of the 0.7.0 changes (like properties being renamed or removed) so for the most part all that is left in the diff is formatting. Therefore, I'd say from my side, the PR ist finished.

It would be great if you could quickly go through the files and fix the http://purl.org/dc/terms vs https://purl.org/dc/terms bug where you find it. Other than that, I think with this and the abovementioned PR, the usage docs appear complete and correct for 0.7.0

@drandarov-io
Copy link
Contributor Author

I believe PR #1241 covered most of the 0.7.0 changes (like properties being renamed or removed) so for the most part all that is left in the diff is formatting. Therefore, I'd say from my side, the PR ist finished.

It would be great if you could quickly go through the files and fix the http://purl.org/dc/terms vs https://purl.org/dc/terms bug where you find it. Other than that, I think with this and the abovementioned PR, the usage docs appear complete and correct for 0.7.0

I've seen that in the Base Connector Repository they've changed all instances of https:// to http://. Is that what it should be or should the walkthrough use https://. I wasn't quite sure of that.

@arnoweiss
Copy link
Contributor

https is wrong. Only http is correct.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wolf4ood wolf4ood merged commit 166c642 into eclipse-tractusx:main Apr 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants