-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update management api walkthrough #1242
Conversation
There's currently a different PR (#1241) open that will likely introduce conflicts to the base branch. Since it's more extensive, I'd suggest merging that one first and then adjusting this one. |
Re-created commit, because commit signature was unverified. |
@drandarov-io #1241 has been merged you can rebase and apply your changes |
Do you intend to add the issues "not considered for now" to this PR? If yes, please convert this back to a draft. If no, this PR covers mostly formatting. |
I believe PR #1241 covered most of the 0.7.0 changes (like properties being renamed or removed) so for the most part all that is left in the diff is formatting. Therefore, I'd say from my side, the PR ist finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i would just fix the DEPENDENCIES file.
You can go here grab the content between
=== Please copy the following content back to DEPENDENCIES ===
...
=== end of content ===
and pasted in the DEPENDENCIES
file and should fix the CI
It would be great if you could quickly go through the files and fix the |
I've seen that in the Base Connector Repository they've changed all instances of |
|
Quality Gate passedIssues Measures |
This is a partial update to the Management API Walkthrough with focus on the payloads and consistency.
Not considered for now: