feat: add new V2 EDR API #1140
Merged
feat: add new V2 EDR API #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4068558 to
ccb6a09
Compare
ccb6a09 to
3a2c099
Compare
54816bb to
c901954
Compare
c901954 to
3d50a46
Compare
wolf4ood
reviewed
Mar 18, 2024
.../edr/edr-api-v2/src/main/java/org/eclipse/tractusx/edc/api/edr/v2/EdrCacheApiController.java
Show resolved
Hide resolved
5930ebb to
8751601
Compare
| return false; | ||
| } | ||
|
|
||
| var expiresIn = Long.parseLong(expiresInString); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
8751601 to
42e8ddf
Compare
|
wolf4ood
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR replicates the
/edrsAPI from EDC upstream, but adds the possibility to refresh EDRs automatically when obtaining them.In addition, the convenience method to negotiated EDRs, that is known from previous versions, was ported over.
WHY
client applications, that simply use the
/edrsapi need a way to have their tokens automatically refreshed while providing a manual way to refresh tokens.FURTHER NOTES
/edrsapi is still available/edrsapi is available under/v2/edrsmatrixtest strategy for e2e testsCloses #1110