feat: implements DIM STS adapter #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7549a0b to
30c8811
Compare
paullatzelsperger
approved these changes
Feb 15, 2024
...p-sts-dim/src/main/java/org/eclipse/tractusx/edc/iam/iatp/sts/dim/DimSecureTokenService.java
Show resolved
Hide resolved
ndr-brt
reviewed
Feb 15, 2024
jimmarino
requested changes
Feb 15, 2024
...sts-dim/src/main/java/org/eclipse/tractusx/edc/iam/iatp/sts/dim/DimOauthClientExtension.java
Show resolved
Hide resolved
| public static final String CREDENTIAL_TYPES = "credentialTypes"; | ||
| public static final String SIGN_TOKEN = "signToken"; | ||
|
|
||
| private final EdcHttpClient httpClient; |
There was a problem hiding this comment.
Do we need these finals?
...p-sts-dim/src/main/java/org/eclipse/tractusx/edc/iam/iatp/sts/dim/DimSecureTokenService.java
Show resolved
Hide resolved
...im/src/main/java/org/eclipse/tractusx/edc/iam/iatp/sts/dim/StsRemoteClientConfiguration.java
Show resolved
Hide resolved
92e9bae to
217267e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Implements a
SecureTokenServicethat talks with DIM.For obtaining an SI token with this implementation first we need to fetch a valid OAuth token with the
DimOauth2Client, then we make two kind of request to DIMgrantAccessfor fetching an SI with thebearerAccessScopesignTokenfor fetching an SI token providing the extractedaccess_tokenfrom the DSP request (SI token)The implementation of
DimOauth2Clientis currently sub-optimal since it's not caching the OAuth token. This will be implemented in subsequent PRsThis PR also ships an E2E test mocking the
OAuthserver and the DIM interactionWHY
iatp integration
Closes #1038