Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Remove rewriting of ENV variable in memory Dockerfile and chart #1039

Closed
KilianHaag opened this issue Feb 9, 2024 · 0 comments · Fixed by #1040
Closed

improvement: Remove rewriting of ENV variable in memory Dockerfile and chart #1039

KilianHaag opened this issue Feb 9, 2024 · 0 comments · Fixed by #1040
Labels
enhancement New feature or request triage all new issues awaiting classification

Comments

@KilianHaag
Copy link
Contributor

WHAT

The chart should set the ENV variable EDC_VAULT_SECRETS instead of SECRETS and the Dockerfile should not set '-Dedc.vault.secrets="${SECRETS}"'

WHY

With the current setup, this is the only ENV variable, that is rewritten. While checking the documentation of the edc components, this rewrite is not apparent. In short: I don't see any reason for it, except potential confusion.

HOW

If accepted I would be happy to create a PR
@KilianHaag KilianHaag added enhancement New feature or request triage all new issues awaiting classification labels Feb 9, 2024
@github-project-automation github-project-automation bot moved this to Open in EDC Board Feb 9, 2024
KilianHaag added a commit to KilianHaag/tractusx-edc that referenced this issue Feb 9, 2024
@KilianHaag
improvement(memory-chart): remove EC_VAULT_SECRETS rewrite
354426c 
resolves eclipse-tractusx#1039
KilianHaag added a commit to KilianHaag/tractusx-edc that referenced this issue Feb 9, 2024
@KilianHaag
improvement(memory-chart): remove EDC_VAULT_SECRETS rewrite
99e32c4 
resolves eclipse-tractusx#1039
@KilianHaag KilianHaag mentioned this issue Feb 9, 2024
Merged
paullatzelsperger pushed a commit that referenced this issue Feb 18, 2024
@KilianHaag
improvement(memory-edc): remove EDC_VAULT_SECRETS rewrite (#1040)
eb250ba 
* improvement(memory-chart): remove EC_VAULT_SECRETS rewrite

resolves #1039

* improvement(memory-chart): remove EDC_VAULT_SECRETS rewrite

resolves #1039
@github-project-automation github-project-automation bot moved this from Open to Done in EDC Board Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage all new issues awaiting classification
Projects
EDC Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement(memory-edc): remove EDC_VAULT_SECRETS rewrite KilianHaag/tractusx-edc
1 participant
@KilianHaag