-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add issue template request promotion #6
feat: add issue template request promotion #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LuisRickert,
cool for checking our the GitHub forms as issue template.
some small things i found.
label: comments | ||
description: "Leave a comment or additional information!" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LuisRickert i think just a single blank line will be ok
title: "[Promote KIT To Incubating]: " | ||
labels: ["kit-promotion"] | ||
assignees: | ||
- octocat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this out if it is not clear who will be responsible @octocat
seems for me to generic
label: comments | ||
description: "Leave a comment or additional information!" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think just a single blank line will be ok 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some further disscussion and changes to this repo could you add a README seciont after the #10 is merged to describe how to handle this promotion requests?
label: "Artefacts & Deliverables" | ||
description: "Tick the provided artefacts and deliverables" | ||
options: | ||
- label: Standarts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not art but Standard ;)
Hi @LuisRickert because this beside the fact more and more KIT´s will be developed... i would prefer a special repo for a special interest group 😉 |
Well, i guess a dedicated Repository is the right way then. edit: typo |
@FaGru3n after several discussions (e.g. with @danielmiehle) I can confirm, that we will "park" the idea of an additional/separate RePo for KITs for the moment. Please work with @kelaja to process all release-relevant issues for KITs also within the SIG Release RePo. We will review the idea towards the and of PI10, once initial learnings can be applied. |
@LuisRickert please dismiss this PullRequest. @danielmiehle will also confirm here, that the initial idea of a template to promote a KIT shall not be used for the time being. Thx, Roland |
I will close the PR according to the message from @RolaH1t |
name: Add request KIT Promotion Issue Template
title: feat add issue templates to request promotion
Description
With this PR we introduce the issue templates to request a promotion for an existing KIT. Raising such an issue will trigger the review process.