Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add issue template request promotion #6

Conversation

LuisRickert
Copy link


name: Add request KIT Promotion Issue Template
title: feat add issue templates to request promotion

Description

With this PR we introduce the issue templates to request a promotion for an existing KIT. Raising such an issue will trigger the review process.

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuisRickert,

cool for checking our the GitHub forms as issue template.

some small things i found.

label: comments
description: "Leave a comment or additional information!"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuisRickert i think just a single blank line will be ok

title: "[Promote KIT To Incubating]: "
labels: ["kit-promotion"]
assignees:
- octocat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this out if it is not clear who will be responsible @octocat seems for me to generic

label: comments
description: "Leave a comment or additional information!"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think just a single blank line will be ok 😉

@LuisRickert LuisRickert requested a review from FaGru3n July 5, 2023 11:41
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some further disscussion and changes to this repo could you add a README seciont after the #10 is merged to describe how to handle this promotion requests?

label: "Artefacts & Deliverables"
description: "Tick the provided artefacts and deliverables"
options:
- label: Standarts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not art but Standard ;)

@FaGru3n
Copy link
Contributor

FaGru3n commented Sep 19, 2023

Hi @LuisRickert because this sig-release repo is getting more in usage of planning and overviewing the release path and processes do you think a new repo would be nice, like "sig-kit" in my opinion it makes it easier to keep on track with the release process and planning things ... and also for the requests against it...?

beside the fact more and more KIT´s will be developed... i would prefer a special repo for a special interest group 😉

@LuisRickert
Copy link
Author

LuisRickert commented Sep 21, 2023

Hi @LuisRickert because this sig-release repo is getting more in usage of planning and overviewing the release path and processes do you think a new repo would be nice, like "sig-kit" in my opinion it makes it easier to keep on track with the release process and planning things ... and also for the requests against it...?

beside the fact more and more KIT´s will be developed... i would prefer a special repo for a special interest group 😉

Well, i guess a dedicated Repository is the right way then.

edit: typo

@RolaH1t
Copy link
Contributor

RolaH1t commented Sep 27, 2023

@FaGru3n after several discussions (e.g. with @danielmiehle) I can confirm, that we will "park" the idea of an additional/separate RePo for KITs for the moment. Please work with @kelaja to process all release-relevant issues for KITs also within the SIG Release RePo. We will review the idea towards the and of PI10, once initial learnings can be applied.

@RolaH1t
Copy link
Contributor

RolaH1t commented Sep 27, 2023

@LuisRickert please dismiss this PullRequest. @danielmiehle will also confirm here, that the initial idea of a template to promote a KIT shall not be used for the time being. Thx, Roland

@FaGru3n
Copy link
Contributor

FaGru3n commented Sep 28, 2023

I will close the PR according to the message from @RolaH1t

@FaGru3n FaGru3n closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants