Fixed some follow ups after restructuring and issues around generator-theia #310

akosyakov · 2017-07-19T10:09:10Z

No description provided.

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

simark · 2017-07-19T11:20:12Z

doc/Developing.md

@@ -41,7 +41,7 @@ This command does a few things:

 ## Run the browser-based example application

-We can start the application with:
+We can start the application from examples/browser directory with:


I'd suggest saying "from the".

simark · 2017-07-19T11:20:56Z

doc/Developing.md

+
+    npm run rebuild:web
+
+It can also be started with from examples/electron directory:


I'd change it to

It can also be started from the examples/electron directory with:

I don't see why someone would want to rollback however ?
Is this more confusing then helping?

Maybe move this to the web basec example section?

After rebuilding for electron, web won't work, but by default web is working. I can put in the web section that if you run npm run rebuild:electron don't forget to run npm run rebuild:web fisrt.

OK yes I was curious about that so this means that since with hoisting we have only 1 node-modules we can only have 1 example at the time without rebuilding :(
But yes sounds better to me in the web section thx

It could be that we can have a setup where we exclude node-pty from hoisting and don't need to run rebuild, but I've spent half a day and failed to come up with such. I think mostly we work with one or another example anyway and later with more experience maybe can overcome it.

Sounds good

simark · 2017-07-19T11:22:20Z

generator-theia/src/common/abstract-generator.ts

@@ -51,7 +51,7 @@ export abstract class AbstractGenerator {
                return `Promise.resolve(${invocation})`;
            }
            return invocation;
-        }).map(statement => `.then(function () { return ${statement}.then(load) })`);
+        }).map(statement => `    .then(function () { return ${statement}.then(load) })`);


What is this change for?

to fix indentation in the generated source files: src-gen/frontend/main.js and src-gen/backend/main.js

Yes thx for that! I had run into trouble with it

hexa00 · 2017-07-19T12:07:59Z

.travis.yml

@@ -21,6 +21,7 @@ before_script:
 before_install:
  - "npm install -g npm@^4"
  - "google-chrome-stable --headless --disable-gpu --remote-debugging-port=9222 http://localhost &"
+bundler_args: --retry 0


Is this travis specific or it's passed to lerna or something ?
I can't find options on lerna or npm and travis ci references bundler_args with the ruby bundler

It is travis specific, depending on provided language travis knows how to build the project, like run npm install first and then npm test for node projects. It also has some defaults for such projects, e.g. for node to try to run npm install 3 times if the first fails, since npmjs sometimes is not available.

hexa00 · 2017-07-19T12:10:01Z

doc/Developing.md

+
+    npm run rebuild:web
+
+It can also be started with from examples/electron directory:


I don't see why someone would want to rollback however ?
Is this more confusing then helping?

Maybe move this to the web basec example section?

hexa00 · 2017-07-19T12:11:00Z

doc/Developing.md

@@ -116,16 +125,17 @@ To build and run the browser example:

    git clone https://github.com/theia-ide/theia \
    && cd theia \
-    && npm install --unsafe-perm\
-    && cd ../../examples/browser \
+    && npm install --unsafe-perm \


BTW we discussed this a bit and --unsafe-perm looks really weird.
I Suggest we move it out of the TL;DR and add it to the troubleshooting section
but that can be in another PR

Could you open an issue for it? or PR :)

hexa00 · 2017-07-19T12:12:22Z

doc/Internals.md

-```
-
-To webpack.config.js so that the requests are proxied to the backend properly.
-


We should update it to say that now the endpoints with /services/* are served by the webpack dev server

hexa00 · 2017-07-19T12:13:18Z

examples/browser/webpack.config.js

-            'safe-json-stringify': emptyPath,
-            'mv': emptyPath,
-            'source-map-support': emptyPath
+            'vs': path.resolve(outputPath, monacoEditorPath)


Why is this not needed for bunyan anymore?

We don't use bunyan in the frontend and use the webpack to build only the frontend, so these modules are never bundled

Right :) thx

hexa00 · 2017-07-19T12:16:33Z

package.json

@@ -10,11 +13,13 @@
    "preinstall": "cd generator-theia && npm install",
    "prepare": "npm install generator-theia && npm run bootstrap && npm run clean && npm run build",
    "prepublishOnly": "npm run test",
-    "bootstrap": "node scripts/generate.js && lerna bootstrap --hoist",
+    "bootstrap": "node scripts/generate.js && lerna bootstrap --hoist -- --no-optional",


What is this doing? (the --no-optional) I'm not sure it's passed to what

Bunyan has some optional dependencies for dtracing and so on, we don't use it, by passing --no-optional we avoid downloading unnecessary dependencies.

OK I still don't see how it goes up to bunyan but will investigate

https://github.com/trentm/node-bunyan/blob/master/package.json#L25 it declares optional dependencies here

So this is passed to npm install in the end? so all modules are with --no-optional?

right, to enable them later we can either remove passing this option or add them explicitly

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

akosyakov added 6 commits July 19, 2017 15:06

#307: fixed ext generation by passing env variables to yo

da86895

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

#268: use / as a file separator in generated imports

0f8189c

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

Fixes #233 and #256: added port and host to the backend app

b87dccd

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

#309: updated tl;dr

e70a143

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

[vscode] added electron debug task

64c9ddc

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

[electron] added a script to rebuild node dependencies

29b824c

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

akosyakov requested review from svenefftinge, hexa00 and simark July 19, 2017 10:09

This was referenced Jul 19, 2017

Assert NPM version #309

Closed

ERR_CONNECTION_REFUSED starting Electron example #308

Closed

akosyakov requested a review from MarkZ3 July 19, 2017 10:10

This was referenced Jul 19, 2017

npm install doesn't seem to work on Windows #307

Closed

Bug in yo theia:browser on windows 10 with git bash #268

Closed

Backend should listen on localhost by default #256

Closed

akosyakov added 2 commits July 19, 2017 15:14

[travis] don't try to rebuild on failure

d2cf122

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

[generator] minor fixes to scripts

2481dfe

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

simark reviewed Jul 19, 2017

View reviewed changes

hexa00 reviewed Jul 19, 2017

View reviewed changes

akosyakov added 2 commits July 19, 2017 17:48

#307 uses cmd to run yo on win32

52a0dfe

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

updated docs

fef2693

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>

svenefftinge approved these changes Jul 19, 2017

View reviewed changes

akosyakov merged commit a62900a into master Jul 20, 2017

akosyakov deleted the ak/restructuring_follow_ups branch July 20, 2017 05:10

magnologan mentioned this pull request Oct 28, 2023

[Snyk] Security upgrade nano from 9.0.5 to 10.1.0 magnologan/theia#17

Open

magnologan mentioned this pull request Dec 27, 2023

[Snyk] Security upgrade nano from 9.0.5 to 10.1.0 magnologan/theia#67

Open

magnologan mentioned this pull request Jan 6, 2024

[Snyk] Security upgrade nano from 9.0.5 to 10.1.0 magnologan/theia#68

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed some follow ups after restructuring and issues around generator-theia #310

Fixed some follow ups after restructuring and issues around generator-theia #310

akosyakov commented Jul 19, 2017

simark Jul 19, 2017

simark Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 19, 2017 •

edited

Loading

hexa00 Jul 19, 2017

simark Jul 19, 2017

akosyakov Jul 19, 2017

hexa00 Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 19, 2017

hexa00 Jul 19, 2017

hexa00 Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 19, 2017 •

edited

Loading

hexa00 Jul 19, 2017

hexa00 Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 19, 2017

hexa00 Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 19, 2017

hexa00 Jul 19, 2017

akosyakov Jul 20, 2017


		npm run rebuild:web

		It can also be started with from examples/electron directory:

		```

		To webpack.config.js so that the requests are proxied to the backend properly.

Fixed some follow ups after restructuring and issues around generator-theia #310

Fixed some follow ups after restructuring and issues around generator-theia #310

Conversation

akosyakov commented Jul 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akosyakov Jul 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akosyakov Jul 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akosyakov Jul 19, 2017 •

edited

Loading

akosyakov Jul 19, 2017 •

edited

Loading