Fix new notebook cell editor outline and width with open right sidebar #14800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It seems because of a monaco upgrade the cell editors recieved an outline. This is removed by this PR.
The width was also calculated wrong when opening the right sidebar or resizing it resulting in a horizontal scrollbar.
How to test
Open a notebook. Cell Editors should look normal without a blue outline inside the editor outline.
Opening the sidebar (for example for the document structure) should not result in a horizontal scrollbar anymore
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers