fixed multiple problems with the notebook output rendering #13239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssociated webview Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
|
I tested the new code, the issue I reported is fixed. Thank you @jonah-iden. |
msujew
reviewed
Jan 10, 2024
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
reviewed
Jan 17, 2024
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fixes #13223
This fixes a few issues with the notebook output rendering and the associated webview.
Also improves performance a bit because the webview is reused when the cell is executed again.
How to test
Create a new notebook or take an existing one. Just try to execute some cells.
Also see #13223 for specific test code. This should now be rendered correctly without extra outputs.
Follow-ups
Review checklist
Reminder for reviewers