fix: delete gen-webpack.node.config.js with theia clean command

[ozfox]

What it does

Fixes #12974 by adding gen-webpack.node.config.js to the clean() method of ApplicationPackageManager.

How to test

1. cd examples/browser
2. yarn build
3. yarn clean && ls -la
4. Verify that gen-webpack.node.config.js
   • was not deleted (without this patch)
   • has been deleted (with this patch

Follow-ups

none

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@ozfox thank you for the contribution, I can confirm that it works as expected:

electron before:

drwxr-xr-x 6 foobar 4096 Oct  5 13:09 .
drwxr-xr-x 7 foobar 4096 Jun 21 15:22 ..
-rw-r--r-- 1 foobar  230 Oct 19  2022 .eslintrc.js
-rw-r--r-- 1 foobar 8495 Oct  5 13:09 gen-webpack.config.js
-rw-r--r-- 1 foobar 4372 Oct  5 13:09 gen-webpack.node.config.js
drwxr-xr-x 7 foobar 4096 Oct  5 13:09 lib
drwxr-xr-x 3 foobar 4096 Oct  5 13:04 node_modules
-rw-r--r-- 1 foobar 2956 Oct  5 13:08 package.json
drwxr-xr-x 4 foobar 4096 Oct  5 13:09 src-gen
drwxr-xr-x 2 foobar 4096 Jun 21 15:22 test
-rw-r--r-- 1 foobar 2577 Sep 28 10:13 tsconfig.json
-rw-r--r-- 1 foobar  640 Jun 21 15:22 webpack.config.js

electron after clean:

drwxr-xr-x 4 foobar 4096 Oct  5 13:15 .
drwxr-xr-x 7 foobar 4096 Jun 21 15:22 ..
-rw-r--r-- 1 foobar  230 Oct 19  2022 .eslintrc.js
drwxr-xr-x 3 foobar 4096 Oct  5 13:04 node_modules
-rw-r--r-- 1 foobar 2956 Oct  5 13:08 package.json
drwxr-xr-x 2 foobar 4096 Jun 21 15:22 test
-rw-r--r-- 1 foobar 2577 Sep 28 10:13 tsconfig.json
-rw-r--r-- 1 foobar  640 Jun 21 15:22 webpack.config.js

browser before:

drwxr-xr-x 5 foobar 4096 Oct  5 13:16 .
drwxr-xr-x 7 foobar 4096 Jun 21 15:22 ..
-rw-r--r-- 1 foobar 8043 Oct  5 13:16 gen-webpack.config.js
-rw-r--r-- 1 foobar 4239 Oct  5 13:16 gen-webpack.node.config.js
drwxr-xr-x 6 foobar 4096 Oct  5 13:17 lib
drwxr-xr-x 3 foobar 4096 Oct  5 13:04 node_modules
-rw-r--r-- 1 foobar 3094 Oct  4 14:28 package.json
drwxr-xr-x 4 foobar 4096 Oct  5 13:16 src-gen
-rw-r--r-- 1 foobar 2587 Sep 29 12:05 tsconfig.json
-rw-r--r-- 1 foobar  645 Jun 21 15:22 webpack.config.js

browser after clean:

drwxr-xr-x 3 foobar 4096 Oct  5 13:18 .
drwxr-xr-x 7 foobar 4096 Jun 21 15:22 ..
drwxr-xr-x 3 foobar 4096 Oct  5 13:04 node_modules
-rw-r--r-- 1 foobar 3094 Oct  4 14:28 package.json
-rw-r--r-- 1 foobar 2587 Sep 29 12:05 tsconfig.json
-rw-r--r-- 1 foobar  645 Jun 21 15:22 webpack.config.js

[bryanchenmchp]

theia clean also doen't remove webpack.config.js, would it be possible to add that change to this PR?

[msujew]

@bryanchenmchp The webpack.config.js file is supposed to be used to create adopter defined overrides of the build process. Deleting that file would also delete any adopter modifications. That is not intended.