Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: perform yarn upgrade #12484

Closed
wants to merge 1 commit into from
Closed

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request performs a yarn upgrade to resolve a known vulnerability with engine.io.
The changes also better reflect what downstream dependents will pull when they build their own Theia-based products.

  • "3PP License Check" review

How to test

  • confirm that CI successfully passes

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added security issues related to security dependencies pull requests that update a dependency file labels May 4, 2023
@vince-fugnitto
Copy link
Member Author

I've noticed with the updates that there are errors regarding "maximum call stack size exceeded":

image

@vince-fugnitto vince-fugnitto force-pushed the vf/yarn-upgrade-engineio branch from ecbbb43 to bf03cb3 Compare May 4, 2023 15:03
The commit performs a `yarn upgrade` to resolve a known vulnerability
with `engine.io`. The changes also better reflect what downstream
dependents will pull when they build their own Theia-based products.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
paul-marechal
paul-marechal previously approved these changes May 8, 2023
@paul-marechal paul-marechal dismissed their stale review May 8, 2023 22:30

Missed the failing 3pp check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file security issues related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants