Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Debug Variable styling fix #12089

Merged

Conversation

FernandoAscencio
Copy link
Contributor

@FernandoAscencio FernandoAscencio commented Jan 19, 2023

What it does

Fixes: #12085 via CSS

The commit fixes the styling of the debug variables tree-view section including:

  • respecting spaces between the variable and the value
  • displaying ellipsis when content takes too much space

image

How to test

Reproduce the steps on #12085

  1. start the application with theia as a workspace
  2. set a breakpoint in a *.spec.ts file
  3. start a debug session with run mocha tests config
  4. confirm the styling of the debug variables is correct (spacing and ellipsis)
  5. add a watch variable
  6. confirm the styling to dismiss the variable is correct

Review checklist

Reminder for reviewers

Signed-off-by: FernandoAscencio fernando.ascencio.cama@ericsson.com

@FernandoAscencio FernandoAscencio force-pushed the VariableTreeViewStyling branch 2 times, most recently from 6f93fd7 to 4e987d1 Compare January 20, 2023 17:30
This commit fixes the lack of spacing between variable and value found
on the Debug Local variables menu

Signed-off-by: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality ui/ux issues related to user interface / user experience labels Jan 20, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I confirmed that:

  • debug variables respect spacing
  • the handling of overflow of debug variables is correctly rendered and displays ellipsis
  • the "dismiss" functionality of "watch expressions" is correctly rendered

@vince-fugnitto vince-fugnitto merged commit 6558a81 into eclipse-theia:master Jan 26, 2023
@FernandoAscencio FernandoAscencio deleted the VariableTreeViewStyling branch January 26, 2023 15:24
@vince-fugnitto vince-fugnitto added this to the 1.34.0 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug: fix styling of variables tree-view part
2 participants