Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco: fixed issue where scrollbar preferences are not being applied #11883

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

EstFoisy
Copy link
Contributor

@EstFoisy EstFoisy commented Nov 18, 2022

What it does

Closes #11732

The pull-request fixes an issue where the horizontal and vertical preferences for the editor were not applied due to defaults overriding the preference value, and incorrectly re-styling monaco with css.

How to test

  1. start the application, and open an editor with enough content the scrollbar appears
  2. confirm that both the vertical and horizontal scrollbar size is correct
  3. update the preference editor.scrollbar.verticalScrollbarSize and confirm the editor's vertical scrollbar is properly updated
  4. update the preference editor.scrollbar.horizontalScrollbarSize and confirm the editor's horizontal scrollbar is properly updated
  5. open a new editor and confirm the preference is properly applied.

Note: the changes only apply for the scrollbar of the editor:
**please note these change only apply to the scrollbar of the editor.

Issue.11732.solved.mp4

Review checklist

Reminder for reviewers

When the horizontal and vertical scrollbar sizes are adjusted in setting
 (in the preference menu), it now apply the scrollbar height or width in
 the editor.
@vince-fugnitto vince-fugnitto added the monaco issues related to monaco label Nov 18, 2022
@vince-fugnitto vince-fugnitto changed the title Scrollbar size settings in preference implemented monaco: fixed issue where scrollbar preferences are not being applied Nov 18, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto requested a review from msujew December 2, 2022 19:43
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

@vince-fugnitto vince-fugnitto merged commit 86b7baa into eclipse-theia:master Dec 6, 2022
@colin-grant-work colin-grant-work added this to the 1.33.0 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbar size settings are "dendrified"
4 participants