Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo: upgrade mocha #11820

Merged
merged 1 commit into from
Nov 1, 2022
Merged

repo: upgrade mocha #11820

merged 1 commit into from
Nov 1, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Oct 31, 2022 •
edited
Loading

What it does

The commit includes the following changes:

  • upgrades lerna
  • upgrades mocha including our config files
  • upgrades minimatch

The main reason of the upgrade was to fix known vulnerabilties and benefit from the newer mocha version.

How to test

  • CI for unit-tests, and the integration tests should pass
  • running individual tests (ex: npx run test @theia/core) should work
  • running individual tests using the run mocha tests launch configuration should work
  • yarn audit should not produce vulnerabilities (jsdom is expected)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto force-pushed the vf/upgrade-mocha branch 2 times, most recently from 9ef5db7 to e4d629a Compare October 31, 2022 16:38
@vince-fugnitto
repo: upgrade mocha
e70178c 
The commit includes the following changes:
- upgrades `lerna`
- upgrades `mocha` including our config files
- upgrades `minimatch`

The main reason of the upgrade was to fix known vulnerabilties and
benefit from the newer mocha version.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto self-assigned this Oct 31, 2022
@vince-fugnitto vince-fugnitto added test issues related to unit and api tests security issues related to security dependencies pull requests that update a dependency file labels Oct 31, 2022
@marcdumais-work marcdumais-work self-requested a review October 31, 2022 18:10
@marcdumais-work
Copy link
Contributor

I tested with a local registry and was able to publish a fictive minor release v1.32.0 based on this PR. I noticed nothing unusual.
I confirmed all seems ok by quickly modifying blueprint to use this new version and it worked:

image

I then locally published a next version, v1.33.0-next.0 without issues.

marcdumais-work
marcdumais-work approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vince.

To be safe I tested a minor and next release locally, including running the tests and all looked good.

@vince-fugnitto vince-fugnitto marked this pull request as ready for review October 31, 2022 19:03
@vince-fugnitto vince-fugnitto merged commit 72fedc0 into master Nov 1, 2022
@vince-fugnitto vince-fugnitto deleted the vf/upgrade-mocha branch November 1, 2022 18:17
@github-actions github-actions bot added this to the 1.32.0 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcdumais-work marcdumais-work marcdumais-work approved these changes

Assignees

@vince-fugnitto vince-fugnitto

Labels
dependencies pull requests that update a dependency file security issues related to security test issues related to unit and api tests
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vince-fugnitto @marcdumais-work