Improve editor preference dendrification #11711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11709 by improving the dendrification of preferences - the old code would clobber e.g.
editor.scrollbar.scrollByPage
when it encounterededitor.scrollbar.horizontal
- and passing user values foreditor.scrollbar.*
preferences, along with defaults for internal (not user-accessible) values.How to test
editor.scrollbar.scrollByPage
totrue
. (and seteditor.find.addExtraSpaceOnTop
tofalse
andeditor.hover.delay
to something long)common-frontend-contribution.ts
).Review checklist
Reminder for reviewers