Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor preference dendrification #11711

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #11709 by improving the dendrification of preferences - the old code would clobber e.g. editor.scrollbar.scrollByPage when it encountered editor.scrollbar.horizontal - and passing user values for editor.scrollbar.* preferences, along with defaults for internal (not user-accessible) values.

How to test

  1. Set the preference editor.scrollbar.scrollByPage to true. (and set editor.find.addExtraSpaceOnTop to false and editor.hover.delay to something long)
  2. Open a big file (I like common-frontend-contribution.ts).
  3. Click on the scrollbar some distance from its current position.
  4. Observe that your preference is respected.
  5. Check the other two preference as well.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the monaco issues related to monaco label Sep 28, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the preferences now work as expected with the steps to test 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some "User" settings not applied to new editors
2 participants