vscode: introduce theia-extra.d.ts
#11684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit creates the `theia-extra.d.ts` file to contain plugin APIs the framework supports on top of the VS Code API. The changes better organize APIs that are not part of the base VS Code API support, and ensure that the comparator passes as well. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
msujew
approved these changes
Sep 23, 2022
colin-grant-work
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request introduces the
theia-extra.d.tsfile which contains plugin APIs which are supported by the framework thanks to our flexibility but not necessarily available in the VS Code API. The APIs are also different thanproposedso a new file was needed to reflect additional APIs Theia supports but VS Code does not.One such case is
WebviewPanel.reveal(which is currently marked as partially supported).How to test
There is no change in functionality:
revealintheia.d.tsmatches VS Code.WebviewPanel.revealas supported.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com