[workspace] Exported RecentWorkspacePathsData type, fixed typo in field name
#11603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2022 18:09
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
| @@ -89,7 +89,7 @@ export class DefaultWorkspaceServer implements WorkspaceServer, BackendApplicati | |||
| * Untitled workspaces that are not among the most recent N workspaces will be deleted on start. Increase this number to keep older files, | |||
| * lower it to delete stale untitled workspaces more aggressively. | |||
| */ | |||
| protected untitledWorkspaceStaleThreshhold = 10; | |||
| protected untitledWorkspaceStaleThreshold = 10; | |||
There was a problem hiding this comment.
The type is unfortunate, but perhaps not worth fixing if it counts as a breaking change?
There was a problem hiding this comment.
The type is unfortunate, but perhaps not worth fixing if it counts as a breaking change?
- I can drop the commit. Probably the fastest. I initially wanted to open the PR for the type
exportonly, then noticed the typo. - I can deprecate the field and introduce a new one. Initially, I did that and wanted to avoid the why do not you rename it? questions, so I changed my mind and renamed it.
- But I am fine also fine leaving the PR as is. There are breaking API changes between patch releases, and this change is documented. I wonder how many extenders subclass the
DefaultWorkspaceServerto override this field 😊
Let me know. Thanks!
There was a problem hiding this comment.
@kittaakos like you said there's a low chance of someone using this API, so fixing the typo now should be fine.
paul-marechal
approved these changes
Aug 24, 2022
|
Thank you for the review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
RecentWorkspacePathsDatatype so that extenders can subclass theprotectedmethods of theDefaultWorkspaceServerclass with proper typing.How to test
No behavioral changes are expected.
Review checklist
Reminder for reviewers