Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace: cleanup multiroot handling #11538

Merged
merged 1 commit into from
Nov 14, 2022
Merged

workspace: cleanup multiroot handling #11538

merged 1 commit into from
Nov 14, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Aug 5, 2022 •
edited
Loading

What it does

Fixes: #11533.

The pull-request mainly removes the workspace.supportMultiRootWorkspace preference.

The change includes:

  • removing workspace.supportMultiRootWorkspace.
  • removing leftover handling for the preference and simplifying methods.
  • adding the workspace section of the File` menu for common workspace commands.
  • updating Save Workspace As... to also work with an unsaved (single folder) workspace and converting it to a saved multiroot workspace.

How to test

  1. confirm that the application start successfully
  2. confirm that single and multi-root workspace are supported (add folder to workspace... works well)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added workspace issues related to the workspace multi-root issues related to multi-root support labels Aug 5, 2022
@vince-fugnitto vince-fugnitto self-assigned this Aug 5, 2022
@vince-fugnitto vince-fugnitto force-pushed the vf/multiroot-cleanup branch 2 times, most recently from 6452274 to b7b0ae0 Compare August 16, 2022 13:51
@vince-fugnitto vince-fugnitto marked this pull request as ready for review August 18, 2022 14:42
@msujew msujew self-requested a review August 18, 2022 14:56
msujew
msujew approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

  • The commands associated to multi root workspaces work as expected (adding/removing)
  • Multi/single root workspaces continue to work as expected
  • The preference isn't visible anymore

@vince-fugnitto
Copy link
Member Author

I'll merge the pull-request after the release to give time to others to take a look if they want to.

@vince-fugnitto vince-fugnitto force-pushed the vf/multiroot-cleanup branch 3 times, most recently from c731c44 to 2c17d8b Compare October 4, 2022 16:27
@vince-fugnitto
workspace: cleanup multiroot handling
5686209 
The commit cleans up leftover code that handled the enablement of
multi-root workspace support.

The commit mainly removes the `workspace.supportMultiRootWorkspace`
preference and handling of the preference since it is no longer needed.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto merged commit 3ac912f into master Nov 14, 2022
@vince-fugnitto vince-fugnitto deleted the vf/multiroot-cleanup branch November 14, 2022 15:13
@github-actions github-actions bot added this to the 1.32.0 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work left review comments

@msujew msujew msujew approved these changes

Assignees

@vince-fugnitto vince-fugnitto

Labels
multi-root issues related to multi-root support workspace issues related to the workspace
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

workspace: remove workspace.supportMultiRootWorkspace preference
3 participants
@vince-fugnitto @msujew @colin-grant-work