Cancel Tree.refresh when new root
set
#11340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
On application startup, these errors are logged by the
scm
package:This PR addresses the error by modifying the logic for handling
set root
on theTreeImpl
so that it cancels arefresh
cycle when a new root is set. Previously,refresh
would continue running and eventually discover that theroot
with which it began no longer corresponded to the currentroot
of the tree, producing the error.How to test
refresh
is called every timeset root
runs, the finalrefresh
should still run to completion.Review checklist
Reminder for reviewers