Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix runtime-import-check plugin #11212

Merged
merged 2 commits into from
May 27, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The commit fixes the runtime-import-check plugin which previously did not work well due to a recent change.

How to test

  1. build the branch
  2. remove the disablement in plugin-api-rpc.ts - should produce an error marker

// eslint-disable-next-line @theia/runtime-import-check
import { PickOptions, QuickInputButtonHandle, QuickPickItem, WidgetOpenerOptions } from '@theia/core/lib/browser';

  1. remove the disablement in hosted-instance-manager.ts - should produce an error marker

// eslint-disable-next-line @theia/runtime-import-check
import { DebugPluginConfiguration } from '@theia/debug/lib/browser/debug-contribution';

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit fixes the `runtime-import-check` plugin which previously did
not work well due to a recent change.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the linting issues related to linting label May 27, 2022
@vince-fugnitto vince-fugnitto self-assigned this May 27, 2022
The commit fixes a `runtime-import-check` error present from
`variable-resolver`. The previous interface `CommandIdVariables` was
defined in `browser` but eventually used in `node`. The commit moves the
interface to `common` so it is safely accessible for `browser` and
`node`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Contributor

@alvsan09 alvsan09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the rule runtime-import-check works 👍
The fix for the 'variable-resolver` works fine as well !!

Thanks Vince!

@vince-fugnitto vince-fugnitto merged commit dbc5742 into master May 27, 2022
@vince-fugnitto vince-fugnitto deleted the vf/fix-runtime-import-check branch May 27, 2022 16:36
@github-actions github-actions bot added this to the 1.27.0 milestone May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting issues related to linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants