-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode: support Terminal#exitStatus
#11175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the change using the provided plugin and it works fine 👍
The code looks good to me, I left a suggestion in inline comments.
One more observation is that you are using the master branch of your fork to trigger the PR,
It's best to create a feature branch containing your changes, you will be able to then work on multiple issues in parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the changes 👍
- Closing the terminal widget manually leads to an
undefined
exit code - If the terminal exits with an error code, it is correctly propagated to the plugin host
- Reloading the browser window does not trigger the terminal closed event.
Signed-off-by: Philippe Ducas <philippe.ducas@ericsson.com>
Signed-off-by: Philippe Ducas <philippe.ducas@ericsson.com>
Signed-off-by: Philippe Ducas <philippe.ducas@ericsson.ca>
What it does
Fixes #11139 by adding support for
Terminal#exitStatus
. This field is set with theTerminalExitStatus
object when the terminal it is referring to is closed, and contains the exit code of its process, if one was provided when terminating.How to test
@vince-fugnitto created a small extension to test this new feature : term-exit-0.0.1.zip
You can fin the source code for this extension on this repository
exit <code>
in the open terminal.<code>
must be an integer between 0 and 255, and will default to 0 if not provided.Test example
Review checklist
Reminder for reviewers
Signed-off-by: Philippe Ducas philippe.ducas@ericsson.com