Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align view container styling with VSCode #10854

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Mar 7, 2022

What it does

Closes #10815

How to test

  1. Compare the view container styling with VSCode (in particular title font weight and border styling)
  2. Try this with different themes.

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label Mar 7, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look much better now 👍 I just noticed one oddity:

  1. start the application using theia as a workspace
  2. add open editors, folder, and npm scripts as tree-view parts
  3. hide open editors - the folder part has a top border

view-styling

@msujew
Copy link
Member Author

msujew commented Mar 7, 2022

@vince-fugnitto You're right, I can reproduce that as well. This cannot be easily handled just with CSS, because the :nth-child(of <selector> syntax is only supported by Safari :/

I'll see how this can be addressed.

@msujew msujew force-pushed the msujew/view-container-border branch from c913c0b to a51a32f Compare March 8, 2022 14:43
@msujew msujew requested a review from vince-fugnitto March 8, 2022 14:44
@msujew
Copy link
Member Author

msujew commented Mar 8, 2022

@vince-fugnitto The final solution is not as clean as previously, but there is no nice way to filter for the first visible view container part using purely CSS.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me, and I confirmed the bug I noticed earlier is fixed 👍

@msujew msujew merged commit 076f0fd into master Mar 11, 2022
@msujew msujew deleted the msujew/view-container-border branch March 11, 2022 13:31
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewContainerParts have same styling as tree nodes (almost)
2 participants