Fix handling malformed recentworkspace.json #10711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vince-fugnitto @paul-marechal thanks for the review and sorry for the CI noise - i should have known this will fail on windows, i've set up a win VM to check locally and fix the tests properly and then get back. |
|
@vince-fugnitto @paul-marechal adapted the tests and resolved your comments. The tests are now running on all platforms. |
|
@colin-grant-work do you mind reviewing the pull-request, I believe you opened the original issue #10250. At least for me on |
3fb6061 to
d0d8e08
Compare
In case a recentworkspace.json contains any non string element in its recentRoots array, the JSON is not considered valid. Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com> fix test on windows Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com> one more try to fix test Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com> use uri for windows to try to make test pass Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com> ignore non-string array entries Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com> Replace check for undefined with null Signed-off-by: Alexander Flammer <alex.flammer.dev@outlook.com>
d0d8e08 to
cc144ee
Compare
colin-grant-work
approved these changes
Feb 14, 2022
thegecko
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Feb 17, 2022
Ensures that the value in the file is an array, and filters out and non-string entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10250.
In case a recentworkspace.json contains any non string element in its recentRoots array, the JSON is not considered valid.
How to test
Run the provided tests.
Adapt your recentworkspace.json file as specified in issue #10250.
Review checklist
Reminder for reviewers