Add option to remove anchor
arg from context menus
#10626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #10540
Fixes #10571
This PR introduces an additional option for the context menu renderer to remove the
anchor
argument included by default, and applies that option in the handlers for menus from the sidebar. Theanchor
argument is used by a number of commands for identifying a specific widget when several could trigger the same context menu, but it is not intended to be used with either of the side panel menus.See #9931 for another example of the problem
How to test
window.menuBarVisibility
preference tocompact
.window.menuBarVisibility
preference tocompact
.Review checklist
Reminder for reviewers