Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view container resize sash options #10425

Closed
wants to merge 1 commit into from
Closed

Add view container resize sash options #10425

wants to merge 1 commit into from

Conversation

kaiyue0329
Copy link
Contributor

@kaiyue0329 kaiyue0329 commented Nov 17, 2021

What it does

Fix: #10416

  • Apply focus to the widget borders when you hover over them
  • sash.hoverDelay controls the hover feedback delay in milliseconds
  • sash.size controls the feedback area size in pixels for the dragging area
  • Add preference to set workbench.sash.hoverDelay (value must in the range of 1 to 2000, default is 1ms)
  • Add preference to set workbench.sash.size (value must in the range of 1 to 20, default is 7px)
sash-option.mov

preference menu

How to test

  1. Start the application
  2. Hover the cursor over the horizontal and vertical borders for different view containers in Theia and drag (please refer to the screencast above for more details)
  3. Search for 'workbench sash' in Preferences (File > Preferences > Open Settings (UI) )
  4. Update the sash.hoverDelay and sash.size preferences to valid values
  5. Repeat Step 2 and verify that the hover delay and feedback area size for the border/sash are updated successfully

Review checklist

Reminder for reviewers

@kaiyue0329 kaiyue0329 closed this Nov 17, 2021
@kaiyue0329 kaiyue0329 deleted the sash-option branch November 17, 2021 15:58
@kaiyue0329 kaiyue0329 restored the sash-option branch November 17, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add window resize "sash" options
1 participant