Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electron] Make the server timeout configurable #3072

Closed
kittaakos opened this issue Oct 4, 2018 · 1 comment
Closed

[electron] Make the server timeout configurable #3072

kittaakos opened this issue Oct 4, 2018 · 1 comment
Labels
electron issues related to the electron target

Comments

@kittaakos
Copy link
Contributor

This one: https://github.com/theia-ide/theia/blob/4eda225bc683633b9a5528b0a327b0b7681cce6e/packages/core/src/node/cluster/main.ts#L28-L32

One can specify the --startup-timeout option, but this approach is not feasible when starting the backend process from the main electron process. I would like to reuse the BackendApplicationConfigProvider so that one can specify a server timeout in the application's package.json if it is not given as an option.

Note: this should work in a bundled electron application.

Thoughts?

CC: @akosyakov
@kittaakos kittaakos added the electron issues related to the electron target label Oct 4, 2018
@kittaakos
Copy link
Contributor Author

Depends on #2624.

kittaakos pushed a commit that referenced this issue Oct 4, 2018
GH-3072: Made the startup-timeout configurable.
54ab1fa 
Adjuted the `appProjectPath` for the backend when running from electron.

Closes: #3072.
Closes: #2624.
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Oct 4, 2018
GH-3072: Made the startup-timeout configurable.
954ac99 
Adjusted the `appProjectPath` for the backend when running from electron.

Closes: #3072.
Closes: #2624.
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Oct 4, 2018
Merged
1 task
kittaakos pushed a commit that referenced this issue Oct 4, 2018
GH-3072: Made the startup-timeout configurable.
ac7f07d 
Adjusted the `appProjectPath` for the backend when running from electron.

Closes: #3072.
Closes: #2624.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Oct 4, 2018
GH-3072: Made the startup-timeout configurable.
fff30e5 
Adjusted the `appProjectPath` for the backend when running from electron.
Replaced the on the fly created application module loader with a function.

Closes: #3072.
Closes: #2624.
Closes: #2992.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Oct 4, 2018
GH-3072: Made the startup-timeout configurable.
0cad0f7 
Adjusted the `appProjectPath` for the backend when running from electron.
Replaced the on the fly created application module loader with a function.

Closes: #3072.
Closes: #2624.
Closes: #2992.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Oct 4, 2018
GH-3072: Made the startup-timeout configurable.
3971e21 
Adjusted the `appProjectPath` for the backend when running from electron.
Replaced the on the fly created application module loader with a function.

Closes: #3072.
Closes: #2624.
Closes: #2992.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Oct 5, 2018
@kittaakos
GH-3072: Made the startup-timeout configurable.
824c6b8 
Adjusted the `appProjectPath` for the backend when running from electron.
Replaced the on the fly created application module loader with a function.

Closes: #3072.
Closes: #2624.
Closes: #2992.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
marcdumais-work pushed a commit to marcdumais-work/theia that referenced this issue Oct 15, 2018
@marcdumais-work
eclipse-theiaGH-3072: Made the startup-timeout configurable.
f13db55 
Adjusted the `appProjectPath` for the backend when running from electron.
Replaced the on the fly created application module loader with a function.

Closes: eclipse-theia#3072.
Closes: eclipse-theia#2624.
Closes: eclipse-theia#2992.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron issues related to the electron target
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kittaakos