We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When binding custom ApplicationShellOptions, they are not properly applied in the ApplicationShell due to a missing assignment.
ApplicationShellOptions
ApplicationShell
rebind(ApplicationShellOptions).toConstantValue(<ApplicationShell.Options>{ leftPanel: { initialSizeRatio: 0.5 } });
The text was updated successfully, but these errors were encountered:
Ensure ApplicationShellOptions are properly used for shell init
57fcc30
Fixes #12982
1a922ed
Ensure ApplicationShellOptions are properly used for shell init (#12983)
f1056b3
martin-fleck-at
Successfully merging a pull request may close this issue.
Bug Description:
When binding custom
ApplicationShellOptions
, they are not properly applied in theApplicationShell
due to a missing assignment.Steps to Reproduce:
rebind(ApplicationShellOptions).toConstantValue(<ApplicationShell.Options>{ leftPanel: { initialSizeRatio: 0.5 } });
or replace the binding in Theia with something that has values (https://github.com/eclipse-theia/theia/blob/master/packages/core/src/browser/frontend-application-module.ts#L163)Additional Information
The text was updated successfully, but these errors were encountered: