Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationShellOptions are not used on ApplicationShell #12982

Closed
martin-fleck-at opened this issue Oct 9, 2023 · 0 comments · Fixed by #12983
Closed

ApplicationShellOptions are not used on ApplicationShell #12982

martin-fleck-at opened this issue Oct 9, 2023 · 0 comments · Fixed by #12983
Assignees

Comments

@martin-fleck-at
Copy link
Contributor

Bug Description:

When binding custom ApplicationShellOptions, they are not properly applied in the ApplicationShell due to a missing assignment.

Steps to Reproduce:

  1. Use a custom re-binding in your application, e.g., rebind(ApplicationShellOptions).toConstantValue(<ApplicationShell.Options>{ leftPanel: { initialSizeRatio: 0.5 } }); or replace the binding in Theia with something that has values (https://github.com/eclipse-theia/theia/blob/master/packages/core/src/browser/frontend-application-module.ts#L163)
  2. Ensure your workspace layout is reset to default.
  3. Expand the left sidebar and see that the wrong ratio is used.

Additional Information

  • Operating System: any
  • Theia Version: master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant