Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: support compounds launch configurations #11302

Closed
vince-fugnitto opened this issue Jun 15, 2022 · 2 comments · Fixed by #11444
Closed

debug: support compounds launch configurations #11302

vince-fugnitto opened this issue Jun 15, 2022 · 2 comments · Fixed by #11444
Labels
debug issues that related to debug functionality

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

The goal is to support compound for debug launch configurations. Currently the compound launch configurations are not present in the dropdown, or supported in the launch.json schema:

image

Steps to Reproduce

  1. start the application using theia as a workspace

  2. open the debug view and select the dropdown

  3. notice that both compound launch configurations are missing

    theia/.vscode/launch.json

    Lines 196 to 216 in f6c0689

    "compounds": [
    {
    "name": "Launch Electron Backend & Frontend",
    "configurations": [
    "Launch Electron Backend",
    "Attach to Plugin Host",
    "Attach to Electron Frontend"
    ],
    "stopAll": true
    },
    {
    "name": "Launch Browser Backend & Frontend",
    "configurations": [
    "Launch Browser Backend",
    "Attach to Plugin Host",
    "Launch Browser Frontend"
    ],
    "stopAll": true
    }
    ]
    }

  4. notice that there is no context assistance for the compounds in the .vscode/launch.json file

@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Jun 15, 2022
@martin-fleck-at
Copy link
Contributor

@vince-fugnitto Do you know if anyone is already working on this? If not I might have a look at it one of these days.

@vince-fugnitto
Copy link
Member Author

@martin-fleck-at I'm not aware of anyone looking into so please go ahead :)

martin-fleck-at added a commit that referenced this issue Aug 11, 2022
Extend debug model for compound launches
- Support pre-launch task, stopAll, list of configurations
- Properly parse compounds into configuration model
- Support mapping to custom session option type
- Support search of options by configuration, compound, and name

Show compound launches in configuration dropdown
- Query all available options
- Use JSON (de-)serialization to allow multiple options with same name
-- Previously custom string was used for identification

- Extend session manager to start compound session options
- Ensure compound sessions can also be found from DebugMain

Minor fixes:
- Prefer select options rendering to bottom in most cases
- Using 'Add Configurations' in dropdown triggers focus-lost on pick
service automatically closing the workspace selection, keep picking open

Fixes #11302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants