Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting Started Widget doesn't accept focus #10878

Closed
colin-grant-work opened this issue Mar 14, 2022 · 12 comments · Fixed by #11807
Closed

Getting Started Widget doesn't accept focus #10878

colin-grant-work opened this issue Mar 14, 2022 · 12 comments · Fixed by #11807
Labels
bug bugs found in the application getting-started issues related to the getting-started extension good first issue good first issues for new contributors

Comments

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Mar 14, 2022 •
edited by JonasHelming
Loading

Bug Description:

Steps to Reproduce:

  1. Open the application with no workspace.
  2. Try to focus the Getting Started Widget.
  3. Observe that the tab is never marked active (brighter text) and you see a log:
root WARN Widget was activated, but did not accept focus after 2000ms: getting.started.widget

in order for a widget to accept focus it needs to implement onActivateRequest and needs something to focus on. The same was done in blueprint for the same view:

eclipse-theia/theia-ide#201

Additional Information

  • Operating System: MacOS, Electron
  • Theia Version: master (e62fd33)
@colin-grant-work colin-grant-work added bug bugs found in the application getting-started issues related to the getting-started extension labels Mar 14, 2022
@alxflam alxflam mentioned this issue Mar 18, 2022
Closed
1 task
@vince-fugnitto vince-fugnitto added the good first issue good first issues for new contributors label Apr 29, 2022
@JonasHelming
Copy link
Contributor

I also saw this behavior with the example widget generated by the Yeoman template. @vince-fugnitto : You marked this with good_first_issue, any idea what is causing this? I am pretty sure, this is a rather new behavior.

@vince-fugnitto
Copy link
Member

I also saw this behavior with the example widget generated by the Yeoman template. @vince-fugnitto : You marked this with good_first_issue, any idea what is causing this? I am pretty sure, this is a rather new behavior.

@JonasHelming since it is a simple fix, in order for a widget to accept focus it needs to implement onActivateRequest and needs something to focus on. The same was done in blueprint for the same view:

@JonasHelming JonasHelming mentioned this issue May 5, 2022
Closed
@WhiteHsu
Copy link
Contributor

WhiteHsu commented Oct 18, 2022 •
edited
Loading

Hello @JonasHelming @vince-fugnitto
This bug is interesting, and I can reproduce it on my site too. Because I would like to learn more about Theia, may I pick up this bug as my first task of this project? Thank you very much. :-)

@JonasHelming
Copy link
Contributor

Yes, we believe it would be a great first task, so please go ahead!

@WhiteHsu
Copy link
Contributor

Thanks! Doing today!

WhiteHsu added a commit to WhiteHsu/theia that referenced this issue Oct 27, 2022
@WhiteHsu
[GH-eclipse-theia#10878] Fix bug of Getting Start Widget Accept Focus
9380f7f
@WhiteHsu WhiteHsu mentioned this issue Oct 27, 2022
Merged
1 task
@WhiteHsu
Copy link
Contributor

hi @JonasHelming @vince-fugnitto
I've raised my PR #11807. Please kindly help review and feedback.

Additionally, my PR has this legal agreement highlight as below. May you suggest what I should do to fix it?
image

Thank you very much!

WhiteHsu added a commit to WhiteHsu/theia that referenced this issue Oct 27, 2022
@WhiteHsu
[GH-eclipse-theia#10878] Fix bug of Getting Start Widget Accept Focus
9b187a3 
Signed-off-by: White Hsu <hsnu97526@email.com>
WhiteHsu added a commit to WhiteHsu/theia that referenced this issue Oct 27, 2022
@WhiteHsu
[GH-eclipse-theia#10878] Fix bug of Getting Start Widget Accept Focus
83fa879 
Signed-off-by: White Hsu <hsnu97526@gmail.com>
WhiteHsu added a commit to WhiteHsu/theia that referenced this issue Nov 17, 2022
@WhiteHsu
[GH-eclipse-theia#10878] Fix bug of Getting Start Widget Accept Focus
52f18c4 
Signed-off-by: White Hsu <hsnu97526@gmail.com>

==
To modify getting-started-contribution.ts to pass activate to the openView methods.
To focus on the first available link in getting-started-widget.tsx.
[Question] But the warning below still exists. May I ask your kind suggestion? Thank you very much.
--
WARN Widget was activated, but did not accept focus after 2000ms: getting.started.widget
--
@JonasHelming
Copy link
Contributor

@WhiteHsu Thank you for working on this!
I think the warning is the main issue described in the bug report, it is fine to keep the current bug until the warning does not show up anymore.

@WhiteHsu
Copy link
Contributor

@JonasHelming got it and thanks for feedback!

Do you suggest another ticket for me? :-)

@JonasHelming
Copy link
Contributor

Are you looking for a new ticket to contribute? I believe @vince-fugnitto commented on this one that there is no element on the page that can accept focus. Does it maybe make sense to add one?

@WhiteHsu
Copy link
Contributor

WhiteHsu commented Jan 3, 2023

Thanks @JonasHelming . Yes I've amended codes accordingly into the PR, and it seems workable without the warning msg. Pls kindly help review and feedback. Thank you. :-)

colin-grant-work pushed a commit that referenced this issue Jan 4, 2023
@WhiteHsu
[GH-#10878] Fix bug of Getting Start Widget Accept Focus (#11807)
066b541 
* [GH-#10878] Fix bug of Getting Start Widget Accept Focus
Signed-off-by: White Hsu <hsnu97526@gmail.com>
@WhiteHsu
Copy link
Contributor

WhiteHsu commented Jan 5, 2023

Many thanks @vince-fugnitto @JonasHelming !

Do you recommend another ticket for me as the 2nd task to get familiar with Theia? :-)

@JonasHelming
Copy link
Contributor

Hi,

you can browse the "good first issues" or the "hackathon" label for more issues to get started.

Best regards,
Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application getting-started issues related to the getting-started extension good first issue good first issues for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-#10878] Fix bug of Getting Start Widget Accept Focus WhiteHsu/theia
4 participants
@JonasHelming @WhiteHsu @vince-fugnitto @colin-grant-work