Update WorkspaceEdit metadata typing

Fixes #13355 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
eclipse-theia · Feb 17, 2024 · c6b67fe · c6b67fe
1 parent f442b7d
commit c6b67fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/packages/plugin-ext/src/plugin/types-impl.ts b/packages/plugin-ext/src/plugin/types-impl.ts
@@ -1869,13 +1869,13 @@ export class WorkspaceEdit implements theia.WorkspaceEdit {
     }
 
     set(uri: URI, edits: ReadonlyArray<TextEdit | SnippetTextEdit>): void;
-    set(uri: URI, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata]>): void;
+    set(uri: URI, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata | undefined]>): void;
     set(uri: URI, edits: ReadonlyArray<NotebookEdit>): void;
-    set(uri: URI, edits: ReadonlyArray<[NotebookEdit, theia.WorkspaceEditEntryMetadata]>): void;
+    set(uri: URI, edits: ReadonlyArray<[NotebookEdit, theia.WorkspaceEditEntryMetadata | undefined]>): void;
 
     set(uri: URI, edits: ReadonlyArray<TextEdit | SnippetTextEdit
-        | NotebookEdit | [NotebookEdit, theia.WorkspaceEditEntryMetadata]
-        | [TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata]>): void {
+        | NotebookEdit | [NotebookEdit, theia.WorkspaceEditEntryMetadata | undefined]
+        | [TextEdit | SnippetTextEdit, theia.WorkspaceEditEntryMetadata | undefined]>): void {
         if (!edits) {
             // remove all text edits for `uri`
             for (let i = 0; i < this._edits.length; i++) {

diff --git a/packages/plugin/src/theia.d.ts b/packages/plugin/src/theia.d.ts
@@ -10258,15 +10258,7 @@ export module '@theia/plugin' {
          * @param uri A resource identifier.
          * @param edits An array of edits.
          */
-        set(uri: Uri, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, WorkspaceEditEntryMetadata]>): void;
-
-        /**
-         * Set (and replace) text edits or snippet edits with metadata for a resource.
-         *
-         * @param uri A resource identifier.
-         * @param edits An array of edits.
-         */
-        set(uri: Uri, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, WorkspaceEditEntryMetadata]>): void;
+        set(uri: Uri, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, WorkspaceEditEntryMetadata | undefined]>): void;
 
         /**
          * Set (and replace) notebook edits for a resource.
@@ -10282,7 +10274,7 @@ export module '@theia/plugin' {
          * @param uri A resource identifier.
          * @param edits An array of edits.
          */
-        set(uri: Uri, edits: ReadonlyArray<[NotebookEdit, WorkspaceEditEntryMetadata]>): void;
+        set(uri: Uri, edits: ReadonlyArray<[NotebookEdit, WorkspaceEditEntryMetadata | undefined]>): void;
 
         /**
          * Get the text edits for a resource.