Upload command always visible on browser

Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>
eclipse-theia · Oct 12, 2022 · 35b0066 · 35b0066
1 parent 807cf6d
commit 35b0066
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/core/src/common/selection-command-handler.ts b/packages/core/src/common/selection-command-handler.ts
@@ -33,7 +33,7 @@ export class SelectionCommandHandler<S> implements CommandHandler {
 
     isVisible(...args: any[]): boolean {
         const selection = this.getSelection(...args);
-        return !!selection && (!this.options.isVisible || (this.options.isVisible as any)(selection as any, ...args));
+        return !this.options.isVisible || (this.options.isVisible as any)(selection as any, ...args);
     }
 
     isEnabled(...args: any[]): boolean {

diff --git a/packages/filesystem/src/browser/filesystem-frontend-contribution.ts b/packages/filesystem/src/browser/filesystem-frontend-contribution.ts
@@ -123,7 +123,7 @@ export class FileSystemFrontendContribution implements FrontendApplicationContri
         commands.registerCommand(FileSystemCommands.UPLOAD, new FileSelection.CommandHandler(this.selectionService, {
             multi: false,
             isEnabled: selection => this.canUpload(selection),
-            isVisible: selection => this.canUpload(selection),
+            isVisible: () => !environment.electron.is(),
             execute: selection => this.upload(selection)
         }));
     }

diff --git a/packages/markers/src/browser/problem/problem-selection.ts b/packages/markers/src/browser/problem/problem-selection.ts
@@ -14,6 +14,7 @@
 // SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
 // *****************************************************************************
 
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { SelectionService } from '@theia/core/lib/common/selection-service';
 import { SelectionCommandHandler } from '@theia/core/lib/common/selection-command-handler';
 import { Marker } from '../../common/marker';
@@ -39,6 +40,11 @@ export namespace ProblemSelection {
                 options
             );
         }
+
+        override isVisible(...args: any[]): boolean {
+            const selection = this.getSelection(...args);
+            return !!selection && super.isVisible(args);
+        }
     }
 
 }