Skip to content

Commit

Permalink
vsx-registry: add hint to fetching extensions error (#12858)
Browse files Browse the repository at this point in the history
Clarifies the error by suggesting it could be caused by network configuration issues.

Contributed by STMicroelectronics
Signed-off-by: Samuel BERG <samuel.berg@st.com>
  • Loading branch information
SamuelBergSTM authored Sep 20, 2023
1 parent 6299414 commit 03d0cb8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)

## v1.42.0

- [vsx-registry] added a hint to extension fetching ENOTFOUND errors [#12858](https://github.com/eclipse-theia/theia/pull/12858) - Contributed by STMicroelectronics

## v1.41.0 - 08/31/2023

- [application-package] added handling to quit the electron app when the backend fails to start [#12778](https://github.com/eclipse-theia/theia/pull/12778) - Contributed on behalf of STMicroelectronics.
Expand Down
4 changes: 3 additions & 1 deletion packages/vsx-registry/src/browser/vsx-extensions-widget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,11 @@ export class VSXExtensionsWidget extends SourceTreeWidget implements BadgeWidget
const searchError = this.extensionsSource.getModel().searchError;
if (!!searchError) {
const message = nls.localize('theia/vsx-registry/errorFetching', 'Error fetching extensions.');
const configurationHint = nls.localize('theia/vsx-registry/errorFetchingConfigurationHint', 'This could be caused by network configuration issues.');
const hint = searchError.includes('ENOTFOUND') ? configurationHint : '';
return <AlertMessage
type='ERROR'
header={`${message} ${searchError}`}
header={`${message} ${searchError} ${hint}`}
/>;
}
}
Expand Down

0 comments on commit 03d0cb8

Please sign in to comment.