Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Rest): License overview is not updating in summary page. #2827

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix(Rest): License overview is not updating in summary page. #2827

merged 1 commit into from
Jan 6, 2025

Conversation

rudra-superrr
Copy link
Contributor

Issue: #2826

Description: The changes will reset the mainLicenceIds and otherLicenseIds data before adding the new license information from .cli file to the summary page.

@rudra-superrr rudra-superrr added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Dec 17, 2024
@rudra-superrr rudra-superrr linked an issue Dec 17, 2024 that may be closed by this pull request
License overview is not updating in summary page #2826
Closed
GMishx
GMishx previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

GMishx
GMishx previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Jan 6, 2025
@rudra-superrr
fix(Rest): License overview is not updating in summary page.
aa11baf 
Signed-off-by: Rudra Chopra <prabhuchopra@gmail.com>
GMishx
GMishx approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Tested, working as expected.

@GMishx GMishx merged commit bbd7a43 into eclipse-sw360:main Jan 6, 2025
3 checks passed
@GMishx GMishx deleted the fix/licenseOverview branch January 6, 2025 07:19
@GMishx GMishx mentioned this pull request Jan 27, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License overview is not updating in summary page
2 participants
@rudra-superrr @GMishx