Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest) : Move GenerateLicenseInfoFile rest end point to SW360reportcontroller #2442

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(rest) : Move GenerateLicenseInfoFile rest end point to SW360reportcontroller #2442

merged 1 commit into from
Oct 17, 2024

Conversation

keerthi-bl
Copy link
Contributor

@keerthi-bl keerthi-bl commented May 6, 2024 •
edited
Loading

Description

Issue reference
Closes #2441

How to reproduce

Sample test :
URL : http://localhost:8080/resource/api/reports?module=licenseInfo&projectId=8fef50eafc484e33bb8ebb33618ed56d&generatorClassName=DocxGenerator&variant=DISCLOSURE

Result :

image

Can download from rest!

@nikkuma7
Copy link
Contributor

Test successful.

image

@nikkuma7
Copy link
Contributor

LicenseInfo-6thOblication-2024-05-10_06_18_51.docx

@keerthi-bl keerthi-bl force-pushed the feat/rest_addConfigToGenericLicInfoReport branch from dea9ea0 to 6479bf0 Compare June 13, 2024 08:20
@keerthi-bl keerthi-bl mentioned this pull request Jun 21, 2024
Merged
@keerthi-bl keerthi-bl force-pushed the feat/rest_addConfigToGenericLicInfoReport branch from 6479bf0 to 58ea963 Compare August 1, 2024 06:04
@GMishx
Copy link
Member

GMishx commented Aug 16, 2024

@keerthi-bl please rebase with latest main to resolve merge conflict.

@keerthi-bl keerthi-bl force-pushed the feat/rest_addConfigToGenericLicInfoReport branch 3 times, most recently from 1bd8689 to b7fa1bb Compare August 29, 2024 06:05
GMishx
GMishx requested changes Aug 31, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing. Rest looks good.

...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/report/SW360ReportService.java Outdated Show resolved Hide resolved
@keerthi-bl keerthi-bl force-pushed the feat/rest_addConfigToGenericLicInfoReport branch from b7fa1bb to 50638c2 Compare October 7, 2024 07:54
GMishx
GMishx approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx added ready ready to merge and removed needs code review labels Oct 17, 2024
@keerthi-bl
feat(rest) : Move GenerateLicenseInfoFile rest end point to SW360repo…
144ea5b 
…rtcontroller

Signed-off-by: Keerthi B L <keerthi.bl@siemens.com>
@keerthi-bl keerthi-bl force-pushed the feat/rest_addConfigToGenericLicInfoReport branch from 50638c2 to 144ea5b Compare October 17, 2024 10:23
@GMishx GMishx merged commit 500514b into eclipse-sw360:main Oct 17, 2024
2 checks passed
@GMishx GMishx deleted the feat/rest_addConfigToGenericLicInfoReport branch October 17, 2024 10:34
@GMishx GMishx mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(rest) : Move GenerateLicenseInfoFile rest end point to SW360reportcontroller.
4 participants
@keerthi-bl @nikkuma7 @GMishx @rudra-superrr