feat(obligation): list license obligation table data #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4fee59 to
a710935
Compare
3ba0737 to
1e2d97d
Compare
|
Test successful |
hoangnt2
reviewed
Feb 29, 2024
| @RequestMapping(value = PROJECTS_URL + "/{id}/licenseObligations", method = RequestMethod.GET) | ||
| public ResponseEntity<HalResource> getLicenseObligations(Pageable pageable, | ||
| @Parameter(description = "Project ID.") @PathVariable("id") String id, HttpServletRequest request) | ||
| throws TException, URISyntaxException, PaginationParameterException, ResourceClassNotFoundException { |
There was a problem hiding this comment.
URISyntaxException, PaginationParameterException, ResourceClassNotFoundException are never thrown
| ) | ||
| @RequestMapping(value = PROJECTS_URL + "/{id}/licenseObligations", method = RequestMethod.GET) | ||
| public ResponseEntity<HalResource> getLicenseObligations(Pageable pageable, | ||
| @Parameter(description = "Project ID.") @PathVariable("id") String id, HttpServletRequest request) |
There was a problem hiding this comment.
unused param HttpServletRequest request
| licenseInfoWithObligations, releaseIdToAcceptedCLI); | ||
| Map<String, String> releaseIdToAcceptedCli = new HashMap<String, String>(); | ||
| obligationStatusMap = licenseObligation.getObligationStatusMap(); | ||
| Map<String, ObligationStatusInfo> newObligationMap = new HashMap<>(); |
| public Map<String, ObligationStatusInfo> setLicenseInfoWithObligations(Map<String, ObligationStatusInfo> obligationStatusMap, Map<String, String> releaseIdToAcceptedCLI, | ||
| List<Release> releases, User user) { | ||
|
|
||
| final Set<Release> excludedReleases = Sets.newHashSet(); |
There was a problem hiding this comment.
Contents of collection excludedReleases are updated at lines 186 and 195, but never queried. Can we remove it ?
| @Test | ||
| public void should_document_get_license_obligations() throws Exception { | ||
| String accessToken = TestHelper.getAccessToken(mockMvc, testUserId, testUserPassword); | ||
| mockMvc.perform(get("/api/projects/" + "123456733" + "/licenseObligations") |
There was a problem hiding this comment.
Id 123456733 should be replaced by project8.getId()
Suggested change
| mockMvc.perform(get("/api/projects/" + "123456733" + "/licenseObligations") | |
| mockMvc.perform(get("/api/projects/" + project8.getId() + "/licenseObligations") |
7cd9cd1 to
8811f76
Compare
|
Review comments addressed. |
|
Code look good to me |
|
Just a tip, you can add Depends-On in github pull request header: |
8811f76 to
c8050fa
Compare
Signed-off-by: Rudra Chopra <prabhuchopra@gmail.com>
c8050fa to
4f65386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #2301
Description:
This new endpoint will list license obligation data for the given project.