Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): revert external id query parsing #2265

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(release): revert external id query parsing #2265

merged 1 commit into from
Jan 15, 2024

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jan 10, 2024

Revert changes done to ReleaseController::searchByExternalIds query parameter parsing.

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

  1. Query releases by external ID.
  2. Check the OpenAPI doc for search releases by external ID endpoint.

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@GMishx
fix(release): revert external id query parsing
625ffcf 
Revert changes done to `ReleaseController::searchByExternalIds`
query parameter parsing.

Signed-off-by: Gaurav Mishra <gmishx@gmail.com>
@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jan 10, 2024
@ag4ums ag4ums self-assigned this Jan 10, 2024
@ag4ums ag4ums removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Jan 15, 2024
ag4ums
ag4ums approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, working as expected

@ag4ums ag4ums merged commit e6dc931 into eclipse-sw360:main Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMishx @ag4ums