feat(CR): Disable Clearing Request creation for the projects which have linked releases without SRC type attachment #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e9b759 to
03b1984
Compare
|
Testing this PR. |
|
Test Successful |
| List<Release> releasesWithoutSRC = new ArrayList<>(); | ||
| Map<String, ProjectReleaseRelationship> releaseIdToUsage = project.getReleaseIdToUsage(); | ||
| Set<String> releaseIdsSet = releaseIdToUsage.keySet(); | ||
| List<String> releaseIdsList = new ArrayList<>(releaseIdsSet); |
There was a problem hiding this comment.
Directly store the Map keys in list.
List releaseIdsList = new ArrayList<>(releaseIdToUsage.keySet());
| @@ -198,6 +198,7 @@ clearing.expert=Clearing Expert | |||
| clearing.progress=Clearing Progress | |||
| clearing.report=Clearing Report | |||
| clearing.request=Clearing Request | |||
| one.or.more.linked.releases.do.not.have.src.type.attachment=One or more linked releases do not have SRC type attachment. | |||
There was a problem hiding this comment.
add this in all language.properties files
…ve linked releases without SRC type attachment Signed-off-by: Akshit Joshi <akshit.joshi@siemens-healthineers.com>
03b1984 to
1ab1435
Compare
|
Hi @rudra-superrr, I have made the changes as you suggested. |
|
code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing Request will not be created if a project has 1 or more linked releases that do not have SRC type attachment,
Issue: #2259
Closes: #2259
How To Test?
Checklist
Must: