feat(rest): Create new endpoint to cancel all scheduled services. #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ceafcb to
8e272bc
Compare
8e272bc to
61f34e3
Compare
1 task
|
Test completed.
|
| The Schedule resource is used to get and list the Schedule requests. | ||
|
|
||
| [[unschedule-services]] | ||
| ==== cancle all schedule. |
There was a problem hiding this comment.
change text to Cancel all Scheduled Services.
cancle -> Cancel
correct this at all places where cancle is used.
| return resource; | ||
| } | ||
|
|
||
| @RequestMapping(value = SCHEDULE_URL + "/unscheduleAllService", method = RequestMethod.DELETE) |
There was a problem hiding this comment.
/unscheduleAllService -> /unscheduleAllServices
61f34e3 to
b739bed
Compare
| The Schedule resource is used to get and list the Schedule requests. | ||
|
|
||
| [[unschedule-services]] | ||
| ==== cancel all schedule. |
There was a problem hiding this comment.
replace it with Cancel all scheduled services.
| @RequestMapping(value = SCHEDULE_URL + "/unscheduleAllServices", method = RequestMethod.DELETE) | ||
| public ResponseEntity<?> unscheduleAllServices()throws TException { | ||
| User sw360User = restControllerHelper.getSw360UserFromAuthentication(); | ||
| RequestStatus requestStatus = scheduleService.cancleAllServices(sw360User); |
There was a problem hiding this comment.
change service name to cancelAllServices from cancleAllServices.
Signed-off-by: Nikesh kumar <kumar.nikesh@simens.com>
b739bed to
3cb73c1
Compare
|
code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2237
Suggest Reviewer
How To Test?
http://localhost:8080/resource/api/schedule/unscheduleAllService
Checklist
Must: